bash completion rules

bash completion rules

You can source this file from bash to add tab-completion of command-line
flags.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120403

[enne (OOO), 2012-02-03 20:23:41]

http://codereview.chromium.org/9320075/diff/1/tools/bash-completion
File tools/bash-completion (right):

http://codereview.chromium.org/9320075/diff/1/tools/bash-completion#newcode15
tools/bash-completion:15: xargs sed -ne 's/.*"\([^"]\+\)".*/--\1/p' | \
Two quick suggestions:

(1) It looks like there's a lot of random strings in comments that get sucked in
too.  Maybe prepending a "-e 's/\/\/.*$//'" would help?

(2) [^"] => [^" ] eliminates a few other bad cases (e.g. "--MAP *")

[Nico, 2012-02-03 20:25:11]

I know nothing about bash completion, looks like enne's got this.

Suggestion: Put it at tools/bash/completion instead.

[Evan Martin, 2012-02-03 21:15:22]

PTAL

diff of the flag list found by the old vs new regex
https://gist.github.com/1732654

stuff like "overlapping" that show up as removed are in comments as you
mentioned:


// Use a custom window style, e.g. --aura-window-mode=compact.
// When this flag is not passed we default to "overlapping" mode.
const char kAuraWindowMode[] = "aura-window-mode";

[Evan Martin, 2012-02-03 21:19:47]

easier to read list of just the removed ones

https://gist.github.com/1732683

[enne (OOO), 2012-02-03 21:27:55]

On 2012/02/03 21:19:47, Evan Martin wrote:
> easier to read list of just the removed ones
> 
> https://gist.github.com/1732683

Thanks, that looks much improved.  :)

[Evan Martin, 2012-02-03 21:29:25]

would you say it looks "good" to you?  :)

[Evan Martin, 2012-02-03 21:29:44]

On 2012/02/03 20:25:11, Nico wrote:
> Suggestion: Put it at tools/bash/completion instead.

Considered this, but there'd only be one file in the dir anyway.

[enne (OOO), 2012-02-03 21:32:50]

On 2012/02/03 21:29:25, Evan Martin wrote:
> would you say it looks "good" to you?  :)

LGTM! *blush*

(Sorry, I'm blind and had missed that you had uploaded that second patch.)

[Nico, 2012-02-03 21:49:44]

On 2012/02/03 21:29:44, Evan Martin wrote:
> On 2012/02/03 20:25:11, Nico wrote:
> > Suggestion: Put it at tools/bash/completion instead.
> 
> Considered this, but there'd only be one file in the dir anyway.

Think big! In the future, there might be, like, 2 files!