Removed IsTransitionType predicate.

Removed IsTransitionType predicate.

With the upcoming changes to CALLBACKS properties, a predicate on the transition
type alone doesn't make sense anymore: For CALLBACKS one has to look into the
property's value to decide, and there is even the possibility of having a an
accessor function *and* a transition in the same property.

I am not completely happy with some parts of this CL, because they contain
redundant code, but given the various representations we currently have for
property type/value pairs, I can see no easy way around that. Perhaps one can
improve this a bit in a different CL, the current diversity really, really hurts
productivity...

As a bonus, this CL includes a few minor things:

 * CaseClause::RecordTypeFeedback has been cleaned up and it handles the
   NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances,
   we previously missed some opportunities for monomorphic calls. In general, it
   is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a
   hack for the inability to remove a descriptor entry during GC, something
   callers shouldn't have to be aware of.

 * DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later
   CALLBACKS-related changes.

 * LookupResult::Print is now more informative for CONSTANT_TRANSITION.

Committed: https://code.google.com/p/v8/source/detail?r=10600

[Jakob Kummerow, 2012-02-03 13:17:13]

LGTM.

http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h#newcode2014
src/objects-inl.h:2014: UNREACHABLE();  // keep the compiler happy
nit: Leading capital letter and trailing period.

http://codereview.chromium.org/9320066/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11143
src/objects.cc:11143: case INTERCEPTOR:
nit: indentation

http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11147
src/objects.cc:11147: UNREACHABLE();  // keep the compiler happy
Missing capital and period.

http://codereview.chromium.org/9320066/diff/1/src/property-details.h
File src/property-details.h (right):

http://codereview.chromium.org/9320066/diff/1/src/property-details.h#newcode1
src/property-details.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

http://codereview.chromium.org/9320066/diff/1/src/property.cc
File src/property.cc (right):

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode1
src/property.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode132
src/property.cc:132: case INTERCEPTOR:
nit: indentation

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode136
src/property.cc:136: UNREACHABLE();  // keep the compiler happy
Missing capital letter and period.

http://codereview.chromium.org/9320066/diff/1/src/property.h
File src/property.h (right):

http://codereview.chromium.org/9320066/diff/1/src/property.h#newcode1
src/property.h:1: // Copyright 2011 the V8 project authors. All rights reserved.
nit: 2012

[Sven Panne, 2012-02-03 13:33:14]

http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h#newcode2014
src/objects-inl.h:2014: UNREACHABLE();  // keep the compiler happy
On 2012/02/03 13:17:14, Jakob wrote:
> nit: Leading capital letter and trailing period.

Done.

http://codereview.chromium.org/9320066/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11143
src/objects.cc:11143: case INTERCEPTOR:
On 2012/02/03 13:17:14, Jakob wrote:
> nit: indentation

Done.

http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11147
src/objects.cc:11147: UNREACHABLE();  // keep the compiler happy
On 2012/02/03 13:17:14, Jakob wrote:
> Missing capital and period.

Done.

http://codereview.chromium.org/9320066/diff/1/src/property-details.h
File src/property-details.h (right):

http://codereview.chromium.org/9320066/diff/1/src/property-details.h#newcode1
src/property-details.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
On 2012/02/03 13:17:14, Jakob wrote:
> nit: 2012

Done.

http://codereview.chromium.org/9320066/diff/1/src/property.cc
File src/property.cc (right):

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode1
src/property.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
On 2012/02/03 13:17:14, Jakob wrote:
> nit: 2012

Done.

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode132
src/property.cc:132: case INTERCEPTOR:
On 2012/02/03 13:17:14, Jakob wrote:
> nit: indentation

Done.

http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode136
src/property.cc:136: UNREACHABLE();  // keep the compiler happy
On 2012/02/03 13:17:14, Jakob wrote:
> Missing capital letter and period.

Done.

http://codereview.chromium.org/9320066/diff/1/src/property.h
File src/property.h (right):

http://codereview.chromium.org/9320066/diff/1/src/property.h#newcode1
src/property.h:1: // Copyright 2011 the V8 project authors. All rights reserved.
On 2012/02/03 13:17:14, Jakob wrote:
> nit: 2012

Done.