Intrinisifed more core library methods: isNaN, isNegative, cos, sin.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 46 matching lines @@
   V(Double, <, Double_lessThan)                                                \
   V(Double, <=, Double_lessEqualThan)                                          \
   V(Double, ==, Double_equal)                                                  \
   V(Double, +, Double_add)                                                     \
   V(Double, -, Double_sub)                                                     \
   V(Double, *, Double_mul)                                                     \
   V(Double, /, Double_div)                                                     \
   V(Double, toDouble, Double_toDouble)                                         \
   V(Double, mulFromInteger, Double_mulFromInteger)                             \
   V(Double, Double.fromInteger, Double_fromInteger)                            \
+  V(Double, isNaN, Double_isNaN)                                               \
+  V(Double, isNegative, Double_isNegative)                                     \
   V(ObjectArray, ObjectArray., ObjectArray_Allocate)                           \
   V(ObjectArray, get:length, Array_getLength)                                  \
   V(ObjectArray, [], Array_getIndexed)                                         \
   V(ObjectArray, []=, Array_setIndexed)                                        \
   V(GrowableObjectArray, get:length, GrowableArray_getLength)                  \
   V(GrowableObjectArray, [], GrowableArray_getIndexed)                         \
   V(GrowableObjectArray, []=, GrowableArray_setIndexed)                        \
   V(ImmutableArray, [], Array_getIndexed)                                      \
   V(ImmutableArray, get:length, Array_getLength)                               \
   V(Math, sqrt, Math_sqrt)                                                     \
+  V(Math, sin, Math_sin)                                                       \
+  V(Math, cos, Math_cos)                                                       \
   V(Object, ==, Object_equal)                                                  \
   V(FixedSizeArrayIterator, next, FixedSizeArrayIterator_next)                 \
   V(FixedSizeArrayIterator, hasNext, FixedSizeArrayIterator_hasNext)           \
   V(StringBase, get:length, String_getLength)                                  \
   V(StringBase, charCodeAt, String_charCodeAt)                                 \
   V(StringBase, hashCode, String_hashCode)                                     \
   V(StringBase, isEmpty, String_isEmpty)                                       \
 
 #define __ assembler->
 
@@ skipping 765 matching lines @@
                                EBX,  // Class register.
                                &fall_through,
                                EAX);  // Result register.
   __ movsd(FieldAddress(EAX, Double::value_offset()), XMM0);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
+static bool Double_isNaN(Assembler* assembler) {
+  const Bool& bool_true = Bool::ZoneHandle(Bool::True());
+  const Bool& bool_false = Bool::ZoneHandle(Bool::False());
+  Label is_true;
+  __ movl(EAX, Address(ESP, +1 * kWordSize));
+  __ movsd(XMM0, FieldAddress(EAX, Double::value_offset()));
+  __ comisd(XMM0, XMM0);
+  __ j(PARITY_EVEN, &is_true, Assembler::kNearJump);  // NaN -> true;
+  __ LoadObject(EAX, bool_false);
+  __ ret();
+  __ Bind(&is_true);
+  __ LoadObject(EAX, bool_true);
+  __ ret();
+  return true;  // Method is complete, no slow case.
+}
+
+
+static bool Double_isNegative(Assembler* assembler) {
+  const Bool& bool_true = Bool::ZoneHandle(Bool::True());
+  const Bool& bool_false = Bool::ZoneHandle(Bool::False());
+  Label is_false, is_true, is_zero, is_nan;
+  __ movl(EAX, Address(ESP, +1 * kWordSize));
+  __ movsd(XMM0, FieldAddress(EAX, Double::value_offset()));
+  __ xorps(XMM1, XMM1);  // 0.0 -> XMM1.
+  __ comisd(XMM0, XMM1);
+  __ j(PARITY_EVEN, &is_nan, Assembler::kNearJump);  // NaN -> false.
+  __ j(EQUAL, &is_zero, Assembler::kNearJump);  // Check for negative zero.
+  __ j(ABOVE_EQUAL, &is_false, Assembler::kNearJump);  // >= 0 -> false.
+  __ Bind(&is_true);
+  __ LoadObject(EAX, bool_true);
+  __ ret();
+  __ Bind(&is_false);
+  __ Bind(&is_nan);

[siva, 2012/02/02 00:04:26]

Why do you want two labels to the same location? Why not just use is_nan for
both cases.

[srdjan, 2012/02/02 19:07:53]

Getting rid of is_nan label. I think it makes more sense than jumping to is_nan
if value is >=0

+  __ LoadObject(EAX, bool_false);
+  __ ret();
+  __ Bind(&is_zero);
+  // Check for negative zero (get the sign bit).
+  __ movmskpd(EAX, XMM0);
+  __ testl(EAX, Immediate(1));
+  __ j(NOT_ZERO, &is_true, Assembler::kNearJump);
+  __ jmp(&is_false, Assembler::kNearJump);
+  return true;  // Method is complete, no slow case.
+}
+
+
 // Argument type is not known
 static bool Math_sqrt(Assembler* assembler) {
   Label fall_through, is_smi, double_op;
   TestLastArgumentIsDouble(assembler, &is_smi, &fall_through);
   // Argument is double and is in EAX, class in EBX.
   __ movsd(XMM1, FieldAddress(EAX, Double::value_offset()));
   __ Bind(&double_op);
   __ sqrtsd(XMM0, XMM1);
   const Class& double_class = Class::ZoneHandle(
       Isolate::Current()->object_store()->double_class());
   __ LoadObject(EBX, double_class);
   AssemblerMacros::TryAllocate(assembler,
                                double_class,
                                EBX,  // Class register.
                                &fall_through,
                                EAX);  // Result register.
   __ movsd(FieldAddress(EAX, Double::value_offset()), XMM0);
   __ ret();
   __ Bind(&is_smi);
   __ SmiUntag(EAX);
   __ cvtsi2sd(XMM1, EAX);
   __ jmp(&double_op);
   __ Bind(&fall_through);
   return false;
 }
 
 
+enum TrigonometricFunctions {
+  kSine,
+  kCosine,
+};
+
+
+static bool EmitTrigonometric(Assembler* assembler,
+                              TrigonometricFunctions kind) {
+  Label fall_through, is_smi, double_op;
+  TestLastArgumentIsDouble(assembler, &is_smi, &fall_through);
+  // Argument is double and is in EAX.
+  __ fldl(FieldAddress(EAX, Double::value_offset()));
+  __ Bind(&double_op);
+  switch (kind) {
+    case kSine:   __ fsin(); break;
+    case kCosine: __ fcos(); break;
+    default:
+      UNREACHABLE();
+  }
+  const Class& double_class = Class::ZoneHandle(
+      Isolate::Current()->object_store()->double_class());
+  __ LoadObject(EBX, double_class);
+  AssemblerMacros::TryAllocate(assembler,
+                               double_class,
+                               EBX,  // Class register.
+                               &fall_through,
+                               EAX);  // Result register.
+  __ fstpl(FieldAddress(EAX, Double::value_offset()));
+  __ ret();
+
+  __ Bind(&is_smi);  // smi -> double.
+  __ SmiUntag(EAX);
+  __ pushl(EAX);
+  __ filds(Address(ESP, 0));
+  __ popl(EAX);
+  __ jmp(&double_op);
+
+  __ Bind(&fall_through);
+}
+
+
+static bool Math_sin(Assembler* assembler) {
+  EmitTrigonometric(assembler, kSine);
+  return false;  // Compile method for slow case.
+}
+
+
+static bool Math_cos(Assembler* assembler) {
+  EmitTrigonometric(assembler, kCosine);
+  return false;  // Compile method for slow case.
+}
+
+
 // Identity comparison.
 static bool Object_equal(Assembler* assembler) {
   Label is_true;
   const Bool& bool_true = Bool::ZoneHandle(Bool::True());
   const Bool& bool_false = Bool::ZoneHandle(Bool::False());
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ cmpl(EAX, Address(ESP, + 2 * kWordSize));
   __ j(EQUAL, &is_true, Assembler::kNearJump);
   __ LoadObject(EAX, bool_false);
   __ ret();
@@ skipping 161 matching lines @@
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32