Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3754)

Unified Diff: chrome/test/data/extensions/api_test/tabs/basics/crud2.js

Issue 9320016: Fix crash in CreateTabFunction::RunImpl(). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: . Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/tabs/basics/crud2.js
diff --git a/chrome/test/data/extensions/api_test/tabs/basics/crud2.js b/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
index 5e0312ce171ca8db9d3a0ebc974782578803aeb9..34a3e5c28c904e5c85f950867f2faa569709aa1c 100644
--- a/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
+++ b/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
@@ -110,6 +110,18 @@ chrome.test.runTests([
});
// Pretend to click a link (openers aren't tracked when using tabs.create).
clickLink("test_link");
- }
+ },
+ // The window on chrome.tabs.create is ignored if it doesn't accept tabs.
+ function testRedirectingToAnotherWindow() {
+ chrome.windows.create(
+ {url: 'about:blank', type: 'popup'},
+ pass(function(window) {
+ chrome.tabs.create(
+ {url: 'about:blank', windowId: window.id},
+ pass(function(tab) {
+ assertTrue(window.id != tab.windowId);
+ }));
+ }));
+ }
]);
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698