Issue 9320016: Fix crash in CreateTabFunction::RunImpl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9320016: Fix crash in CreateTabFunction::RunImpl(). (Closed)

Created:
8 years, 10 months ago by jstritar

Modified:
8 years, 10 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, jennb

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Fix crash in CreateTabFunction::RunImpl(). BUG=112314 TEST=ExtensionApiTest.Tabs2 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120121

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_tabs_module.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/tabs/basics/crud2.js	View		1 chunk	+13 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jstritar@chromium.org/9320016/1

8 years, 10 months ago (2012-02-01 21:47:36 UTC) #3

jstritar

8 years, 10 months ago (2012-02-01 22:29:04 UTC) #4

+jennb FYI

We refresh the tab_strip pointer right after the Navigate call now, to stop the
crash and make sure the opener is correct.