Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 9320007: WebSpeechInputResult::set() was renamed to assign() (Closed)

Created:
8 years, 10 months ago by hans
Modified:
8 years, 10 months ago
Reviewers:
Satish, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

WebSpeechInputResult::set() was renamed to assign() BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120748

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/speech_input_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
hans
This depends on https://bugs.webkit.org/show_bug.cgi?id=77540
8 years, 10 months ago (2012-02-01 11:03:43 UTC) #1
hans
8 years, 10 months ago (2012-02-03 15:06:45 UTC) #2
Satish
lgtm
8 years, 10 months ago (2012-02-03 15:14:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/9320007/3001
8 years, 10 months ago (2012-02-06 11:56:56 UTC) #4
commit-bot: I haz the power
Presubmit check for 9320007-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-06 11:56:58 UTC) #5
hans
piman: OWNER's approval?
8 years, 10 months ago (2012-02-06 11:58:19 UTC) #6
piman
On 2012/02/06 11:58:19, hans wrote: > piman: OWNER's approval? rubber stamp LGTM
8 years, 10 months ago (2012-02-06 17:12:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/9320007/3001
8 years, 10 months ago (2012-02-06 17:14:15 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-06 18:59:45 UTC) #9
Try job failure for 9320007-3001 (retry) on mac_rel for step "test_shell_tests".
It's a second try, previously, steps "test_shell_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698