Issue 9318017: [NTP4] Redesign of notification promo.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -30 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.css	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View	1 2 3 4 5 6 7 8 9 10 11	3 chunks	+21 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 2 3 4 5 6 7 8	9 chunks	+110 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/ntp4/page_list_view.js	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.css	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.js	View	1 2 3 4 5 6 7 8	3 chunks	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/card_slider.js	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/parse_html_subset.js	View	1 2 3 4 5 6	4 chunks	+31 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

there might be a tiny bit of close button tweaking left here, but otherwise good ...

8 years, 10 months ago (2012-02-01 05:21:47 UTC) #1

Evan Stade

lgtm https://chromiumcodereview.appspot.com/9318017/diff/3012/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): https://chromiumcodereview.appspot.com/9318017/diff/3012/chrome/browser/resources/ntp4/new_tab.js#newcode222 chrome/browser/resources/ntp4/new_tab.js:222: while (readyCallbacks.length) I think curlies here https://chromiumcodereview.appspot.com/9318017/diff/3012/chrome/browser/resources/ntp4/tile_page.js File ...

8 years, 10 months ago (2012-02-07 01:07:21 UTC) #3

Dan Beam

https://chromiumcodereview.appspot.com/9318017/diff/3012/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): https://chromiumcodereview.appspot.com/9318017/diff/3012/chrome/browser/resources/ntp4/new_tab.js#newcode222 chrome/browser/resources/ntp4/new_tab.js:222: while (readyCallbacks.length) On 2012/02/07 01:07:21, Evan Stade wrote: > ...

8 years, 10 months ago (2012-02-07 01:42:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9318017/15002

8 years, 10 months ago (2012-02-07 04:19:12 UTC) #6

commit-bot: I haz the power

8 years, 10 months ago (2012-02-07 06:39:34 UTC) #7

Try job failure for 9318017-15002 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages

Issue 9318017: [NTP4] Redesign of notification promo. (Closed)

Description

Patch Set 1 #

Patch Set 2 : adding docs #

Patch Set 3 : more docs #

Patch Set 4 : bug fixes #

Patch Set 5 : allowing imgs with data URIs #

Patch Set 6 : refactor #

Patch Set 7 : time travel #

Patch Set 8 : fixes according to style guide #

Patch Set 9 : rebase, back out of style changes (done in other CL), review comments #

Patch Set 10 : fixing RTL #

Patch Set 11 : move CSS, add back rule I accidentally deleted #

Patch Set 12 : rebase #

Messages