Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 9318014: Add SwiftShader copyright info and logo to about:credits. (Closed)

Created:
8 years, 10 months ago by jbauman
Modified:
8 years, 10 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org, Mark Larson
Visibility:
Public.

Description

Add SwiftShader copyright info and logo to about:credits. Adds support to tools/licenses.py for including html in about:credits, and use to include SwiftShader's logo and license info. BUG=112611 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120377

Patch Set 1 #

Patch Set 2 : fix format a bit #

Patch Set 3 : Use a "Required Text" section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M chrome/browser/resources/about_credits.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/about_credits_entry.tmpl View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/swiftshader.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/swiftshader/LICENSE View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/swiftshader/README.chromium View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/swiftshader/required.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/licenses.py View 1 2 7 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
8 years, 10 months ago (2012-01-31 23:31:34 UTC) #1
Evan Martin
Why include the logo? This LICENSE file doesn't appear to be a software licence... ?
8 years, 10 months ago (2012-01-31 23:35:10 UTC) #2
Evan Martin
Rather than adding a "logo" keyword (which may tempt others to add it to other ...
8 years, 10 months ago (2012-01-31 23:50:03 UTC) #3
jbauman
On 2012/01/31 23:50:03, Evan Martin wrote: > Rather than adding a "logo" keyword (which may ...
8 years, 10 months ago (2012-01-31 23:50:48 UTC) #4
jbauman
On 2012/01/31 23:50:03, Evan Martin wrote: > Rather than adding a "logo" keyword (which may ...
8 years, 10 months ago (2012-02-01 00:19:29 UTC) #5
Evan Martin
LGTM Is the <img src> enough for the image to actually show up in the ...
8 years, 10 months ago (2012-02-01 00:23:07 UTC) #6
jbauman
On 2012/02/01 00:23:07, Evan Martin wrote: > LGTM > > Is the <img src> enough ...
8 years, 10 months ago (2012-02-01 00:27:29 UTC) #7
Evan Stade
the jpeg gets flattened into a data url by grit lgtm
8 years, 10 months ago (2012-02-01 05:10:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9318014/3002
8 years, 10 months ago (2012-02-03 18:29:51 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-03 18:33:16 UTC) #10
Try job failure for 9318014-3002 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698