[uber page] Fix the missing cancel button on the settings search field.

chrome/browser/resources/options2/options_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /////////////////////////////////////////////////////////////////////////////
   // OptionsPage class:
 
   /**
    * Base class for options page.
@@ skipping 705 matching lines @@
    * Updates all frozen pages to match the horizontal scroll position.
    * @private
    */
   OptionsPage.updateAllFrozenElementPositions_ = function() {
     var frozenElements = document.querySelectorAll('.frozen');
     for (var i = 0; i < frozenElements.length; i++)
       this.updateFrozenElementHorizontalPosition_(frozenElements[i]);
   };
 
   /**
-   * Update the left of all the position: fixed; header elements.
+   * Update the start margin of all the position: fixed; header elements.
    * @private
    */
   OptionsPage.updateAllHeaderElementPositions_ = function() {
-    var translate = 'translateX(' + (document.body.scrollLeft * -1) + 'px)';
+    var adjust = document.documentElement.dir == 'rtl' ? 1 : -1;

[Dan Beam, 2012/01/31 22:49:49]

use isRTL()

[csilv, 2012/01/31 23:45:19]

Done.

+    var marginStart = (document.body.scrollLeft * adjust) + 'px';

[Dan Beam, 2012/01/31 22:49:49]

the JavaScript style guide would probably want to you remove these () as neither
order of operations nor * operator are ambiguous.

[csilv, 2012/01/31 23:45:19]

Done.

     for (var i = 0; i < this.fixedHeaders_.length; ++i)
-      this.fixedHeaders_[i].style.webkitTransform = translate;
+      this.fixedHeaders_[i].style.webkitMarginStart = marginStart;
 
     uber.invokeMethodOnParent('adjustToScroll', document.body.scrollLeft);
   };
 
   /**
    * Updates the given frozen element to match the horizontal scroll position.
    * @param {HTMLElement} e The frozen element to update
    * @private
    */
   OptionsPage.updateFrozenElementHorizontalPosition_ = function(e) {
@@ skipping 359 matching lines @@
     canShowPage: function() {
       return true;
     },
   };
 
   // Export
   return {
     OptionsPage: OptionsPage
   };
 });