Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/test/perf/rendering/throughput_tests.cc

Issue 9318008: Make throughput test wait for page to load before starting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/rendering/throughput_tests.cc
diff --git a/chrome/test/perf/rendering/throughput_tests.cc b/chrome/test/perf/rendering/throughput_tests.cc
index 37b5e33dbb0f515d3f49b5da6d7f896868f76940..ba5532a9ad84f43f31b53b63cf08fafbaa15cd3b 100644
--- a/chrome/test/perf/rendering/throughput_tests.cc
+++ b/chrome/test/perf/rendering/throughput_tests.cc
@@ -6,6 +6,7 @@
#include "base/path_service.h"
#include "base/stringprintf.h"
#include "base/test/trace_event_analyzer.h"
+#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/test_switches.h"
@@ -27,7 +28,7 @@ enum ThroughputTestFlags {
kInternal = 1 << 0 // Test uses internal test data.
};
-const int kSpinUpTimeMs = 5 * 1000;
+const int kSpinUpTimeMs = 4 * 1000;
const int kRunTimeMs = 10 * 1000;
const int kIgnoreSomeFrames = 3;
@@ -118,6 +119,7 @@ class ThroughputTest : public BrowserPerfTest {
LOG(INFO) << gurl.possibly_invalid_spec();
ui_test_utils::NavigateToURLWithDisposition(
browser(), gurl, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
+ ui_test_utils::WaitForLoadStop(browser()->GetSelectedWebContents());
// Let the test spin up.
LOG(INFO) << "Spinning up test...\n";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698