Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: webkit/tools/test_shell/mock_webclipboard_impl.cc

Issue 9318003: Update WebClipboard/WebDropData glue to use new getter/setter for WebDragData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/mock_webclipboard_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/mock_webclipboard_impl.cc
diff --git a/webkit/tools/test_shell/mock_webclipboard_impl.cc b/webkit/tools/test_shell/mock_webclipboard_impl.cc
index 4f67c707e92a846d814cdb1e900711ddc8b207fb..f36e23285c31ac914981b3ee93bdcd90833bb196 100644
--- a/webkit/tools/test_shell/mock_webclipboard_impl.cc
+++ b/webkit/tools/test_shell/mock_webclipboard_impl.cc
@@ -9,11 +9,12 @@
#include "base/logging.h"
#include "base/stl_util.h"
#include "base/string_util.h"
-#include "net/base/escape.h"
+#include "base/utf_string_conversions.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCommon.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebDragData.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebImage.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURL.h"
+#include "ui/base/clipboard/clipboard.h"
#include "webkit/glue/webclipboard_impl.h"
#include "webkit/glue/webkit_glue.h"
#include "webkit/support/webkit_support_gfx.h"
@@ -78,10 +79,11 @@ WebVector<WebString> MockWebClipboardImpl::readAvailableTypes(
if (!m_image.isNull()) {
results.push_back(WebString("image/png"));
}
- for (size_t i = 0; i < m_customData.size(); ++i) {
- CHECK(std::find(results.begin(), results.end(), m_customData[i].type) ==
+ for (std::map<string16, string16>::const_iterator it = m_customData.begin();
+ it != m_customData.end(); ++it) {
+ CHECK(std::find(results.begin(), results.end(), it->first) ==
results.end());
- results.push_back(m_customData[i].type);
+ results.push_back(it->first);
}
return results;
}
@@ -135,58 +137,79 @@ WebKit::WebData MockWebClipboardImpl::readImage(
WebKit::WebString MockWebClipboardImpl::readCustomData(
WebKit::WebClipboard::Buffer buffer,
const WebKit::WebString& type) {
- for (size_t i = 0; i < m_customData.size(); ++i) {
- if (m_customData[i].type == type) {
- return m_customData[i].data;
- }
- }
+ std::map<string16, string16>::const_iterator it = m_customData.find(type);
+ if (it != m_customData.end())
+ return it->second;
return WebKit::WebString();
}
void MockWebClipboardImpl::writeHTML(
const WebKit::WebString& htmlText, const WebKit::WebURL& url,
const WebKit::WebString& plainText, bool writeSmartPaste) {
+ clear();
+
m_htmlText = htmlText;
m_plainText = plainText;
- m_image.reset();
- m_customData = WebVector<WebDragData::CustomData>();
m_writeSmartPaste = writeSmartPaste;
}
void MockWebClipboardImpl::writePlainText(const WebKit::WebString& plain_text) {
- m_htmlText = WebKit::WebString();
+ clear();
+
m_plainText = plain_text;
- m_image.reset();
- m_customData = WebVector<WebDragData::CustomData>();
- m_writeSmartPaste = false;
}
void MockWebClipboardImpl::writeURL(
const WebKit::WebURL& url, const WebKit::WebString& title) {
+ clear();
+
m_htmlText = WebString::fromUTF8(
webkit_glue::WebClipboardImpl::URLToMarkup(url, title));
m_plainText = url.spec().utf16();
- m_image.reset();
- m_customData = WebVector<WebDragData::CustomData>();
- m_writeSmartPaste = false;
}
void MockWebClipboardImpl::writeImage(const WebKit::WebImage& image,
const WebKit::WebURL& url, const WebKit::WebString& title) {
if (!image.isNull()) {
+ clear();
+
+ m_plainText = m_htmlText;
m_htmlText = WebString::fromUTF8(
webkit_glue::WebClipboardImpl::URLToImageMarkup(url, title));
- m_plainText = m_htmlText;
m_image = image;
- m_customData = WebVector<WebDragData::CustomData>();
- m_writeSmartPaste = false;
}
}
-void MockWebClipboardImpl::writeDataObject(const WebKit::WebDragData& data) {
- m_htmlText = data.htmlText();
- m_plainText = data.plainText();
+void MockWebClipboardImpl::writeDataObject(const WebDragData& data) {
+ clear();
+
+ const WebVector<WebDragData::Item>& itemList = data.items();
+ for (size_t i = 0; i < itemList.size(); ++i) {
+ const WebDragData::Item& item = itemList[i];
+ switch (item.storageType) {
+ case WebDragData::Item::StorageTypeString: {
+ if (EqualsASCII(item.stringType, ui::Clipboard::kMimeTypeText)) {
+ m_plainText = item.stringData;
+ continue;
+ }
+ if (EqualsASCII(item.stringType, ui::Clipboard::kMimeTypeHTML)) {
+ m_htmlText = item.stringData;
+ continue;
+ }
+ m_customData.insert(std::make_pair(item.stringType, item.stringData));
+ continue;
+ }
+ case WebDragData::Item::StorageTypeFilename:
+ case WebDragData::Item::StorageTypeBinaryData:
+ NOTREACHED(); // Currently unused by the clipboard implementation.
+ }
+ }
+}
+
+void MockWebClipboardImpl::clear() {
+ m_plainText = WebString();
+ m_htmlText = WebString();
m_image.reset();
- m_customData = data.customData();
+ m_customData.clear();
m_writeSmartPaste = false;
}
« no previous file with comments | « webkit/tools/test_shell/mock_webclipboard_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698