Update WebClipboard/WebDropData glue to use new getter/setter for WebDragData.

Update WebClipboard/WebDropData glue to use new getter/setters for WebDragData.

This change will help us implement the HTML spec for DataTransferItemList correctly.

BUG=112255
TEST=manual + WebKit layout tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122370

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122469

[dcheng, 2012-02-01 08:07:34]

This patch depends on https://bugs.webkit.org/show_bug.cgi?id=77125. Once the WK
patch lands and is rolled into Chromium, I'll land this patch and then update WK
to remove the legacy accessors.

[tony, 2012-02-03 20:35:01]

LGTM, just some style nits.

http://codereview.chromium.org/9318003/diff/4001/ui/base/clipboard/clipboard.h
File ui/base/clipboard/clipboard.h (right):

http://codereview.chromium.org/9318003/diff/4001/ui/base/clipboard/clipboard....
ui/base/clipboard/clipboard.h:49: static const char kMimeTypePNG[];
Do you need to export these?

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc
File webkit/glue/webdropdata.cc (right):

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:30: if (type == ui::Clipboard::kMimeTypeText) {
Should we use EqualsASCII from base/string_util.h?

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:32: continue;
break seems better to me than continue (here and below).  Seems more obvious
what we're doing.

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:50: }
bad indent?

[dcheng, 2012-02-03 21:37:59]

http://codereview.chromium.org/9318003/diff/4001/ui/base/clipboard/clipboard.h
File ui/base/clipboard/clipboard.h (right):

http://codereview.chromium.org/9318003/diff/4001/ui/base/clipboard/clipboard....
ui/base/clipboard/clipboard.h:49: static const char kMimeTypePNG[];
On 2012/02/03 20:35:01, tony wrote:
> Do you need to export these?

I wasn't sure, since the base class is wrapped in an UI_EXPORT macro. I'll test
it before landing.

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc
File webkit/glue/webdropdata.cc (right):

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:30: if (type == ui::Clipboard::kMimeTypeText) {
On 2012/02/03 20:35:01, tony wrote:
> Should we use EqualsASCII from base/string_util.h?

Done. I updated the mock web clipboard implementation for DRT as well.

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:32: continue;
On 2012/02/03 20:35:01, tony wrote:
> break seems better to me than continue (here and below).  Seems more obvious
> what we're doing.

Done.

http://codereview.chromium.org/9318003/diff/4001/webkit/glue/webdropdata.cc#n...
webkit/glue/webdropdata.cc:50: }
On 2012/02/03 20:35:01, tony wrote:
> bad indent?

Done.

[commit-bot: I haz the power, 2012-02-16 19:18:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/9318003/11001

[commit-bot: I haz the power, 2012-02-16 19:18:27]

Presubmit check for 9318003-11001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/base/clipboard/clipboard.cc,ui/base/clipboard/clipboard.h

[dcheng, 2012-02-16 19:19:31]

+sky for OWNERS approval for ui/base/clipboard

[sky, 2012-02-16 22:20:56]

LGTM