Issue 9317119: Consolidated property counting methods a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317119: Consolidated property counting methods a bit. (Closed)

Created:
8 years, 10 months ago by Sven Panne

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Consolidated property counting methods a bit. Committed: https://code.google.com/p/v8/source/detail?r=10611

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -30 lines)			Patch
M	src/handles.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	3 chunks	+9 lines, -21 lines	2 comments	Download
M	src/runtime.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. I like cleanup :-) http://codereview.chromium.org/9317119/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/9317119/diff/1/src/objects.cc#newcode4254 src/objects.cc:4254: PropertyDetails details(descs->GetDetails(i)); nit: indentation

8 years, 10 months ago (2012-02-06 13:18:35 UTC) #2

Sven Panne

8 years, 10 months ago (2012-02-06 13:37:29 UTC) #3

http://codereview.chromium.org/9317119/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9317119/diff/1/src/objects.cc#newcode4254
src/objects.cc:4254: PropertyDetails details(descs->GetDetails(i));
On 2012/02/06 13:18:35, Jakob wrote:
> nit: indentation

Done.

Expand Messages | Collapse Messages