Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Unified Diff: chrome/browser/ui/webui/options2/browser_options_handler2.cc

Issue 9317114: Settings: Clean up browser_options page according to style guide. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/browser_options_handler2.cc
diff --git a/chrome/browser/ui/webui/options2/browser_options_handler2.cc b/chrome/browser/ui/webui/options2/browser_options_handler2.cc
index fb34661ee954cf108ae240a0ee53836d700cd79e..2342e7f2c6fde49547f5ffda728fc355583a2d8a 100644
--- a/chrome/browser/ui/webui/options2/browser_options_handler2.cc
+++ b/chrome/browser/ui/webui/options2/browser_options_handler2.cc
@@ -111,7 +111,7 @@ void BrowserOptionsHandler::GetLocalizedValues(
DCHECK(localized_strings);
static OptionsStringResource resources[] = {
- { "advancedOptionsButtonTitle", IDS_OPTIONS_ADVANCED_BUTTON_TITLE },
+ { "advancedSettings", IDS_OPTIONS_ADVANCED_BUTTON_TITLE },
{ "autologinEnabled", IDS_OPTIONS_PASSWORDS_AUTOLOGIN },
{ "browsingData", IDS_OPTIONS_BROWSING_DATA_GROUP_NAME }, // needed?
{ "changeHomePage", IDS_OPTIONS_CHANGE_HOME_PAGE },
@@ -136,6 +136,7 @@ void BrowserOptionsHandler::GetLocalizedValues(
{ "sectionTitleSearch", IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME },
{ "sectionTitleStartup", IDS_OPTIONS_STARTUP_GROUP_NAME },
{ "sectionTitleSync", IDS_SYNC_OPTIONS_GROUP_NAME },
+ { "settingsTitle", IDS_SETTINGS_TITLE },
{ "startupSetPages", IDS_OPTIONS2_STARTUP_SET_PAGES },
{ "startupShowDefaultAndNewTab",
IDS_OPTIONS_STARTUP_SHOW_DEFAULT_AND_NEWTAB},
@@ -178,7 +179,6 @@ void BrowserOptionsHandler::GetLocalizedValues(
};
RegisterStrings(localized_strings, resources, arraysize(resources));
- RegisterTitle(localized_strings, "browserPage", IDS_SETTINGS_TITLE);
localized_strings->SetString(
"syncOverview",

Powered by Google App Engine
This is Rietveld 408576698