Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/ui/webui/options2/options2_browsertest.js

Issue 9317114: Settings: Clean up browser_options page according to style guide. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * TestFixture for OptionsPage WebUI testing. 6 * TestFixture for OptionsPage WebUI testing.
7 * @extends {testing.Test} 7 * @extends {testing.Test}
8 * @constructor 8 * @constructor
9 */ 9 */
10 function OptionsWebUITest() {} 10 function OptionsWebUITest() {}
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // Crashes on Mac only. See http://crbug.com/79181 48 // Crashes on Mac only. See http://crbug.com/79181
49 GEN('#if defined(OS_MACOSX)'); 49 GEN('#if defined(OS_MACOSX)');
50 GEN('#define MAYBE_testSetBooleanPrefTriggers ' + 50 GEN('#define MAYBE_testSetBooleanPrefTriggers ' +
51 'DISABLED_testSetBooleanPrefTriggers'); 51 'DISABLED_testSetBooleanPrefTriggers');
52 GEN('#else'); 52 GEN('#else');
53 GEN('#define MAYBE_testSetBooleanPrefTriggers testSetBooleanPrefTriggers'); 53 GEN('#define MAYBE_testSetBooleanPrefTriggers testSetBooleanPrefTriggers');
54 GEN('#endif // defined(OS_MACOSX)'); 54 GEN('#endif // defined(OS_MACOSX)');
55 55
56 TEST_F('OptionsWebUITest', 'MAYBE_testSetBooleanPrefTriggers', function() { 56 TEST_F('OptionsWebUITest', 'MAYBE_testSetBooleanPrefTriggers', function() {
57 // TODO(dtseng): make generic to click all buttons. 57 // TODO(dtseng): make generic to click all buttons.
58 var showHomeButton = $('toolbarShowHomeButton'); 58 var showHomeButton = $('toolbar-show-home-button');
59 var trueListValue = [ 59 var trueListValue = [
60 'browser.show_home_button', 60 'browser.show_home_button',
61 true, 61 true,
62 'Options_Homepage_HomeButton', 62 'Options_Homepage_HomeButton',
63 ]; 63 ];
64 // Note: this expectation is checked in testing::Test::tearDown. 64 // Note: this expectation is checked in testing::Test::tearDown.
65 this.mockHandler.expects(once()).setBooleanPref(trueListValue); 65 this.mockHandler.expects(once()).setBooleanPref(trueListValue);
66 66
67 // Cause the handler to be called. 67 // Cause the handler to be called.
68 showHomeButton.click(); 68 showHomeButton.click();
(...skipping 15 matching lines...) Expand all
84 item.onclick(); 84 item.onclick();
85 window.location.reload(); 85 window.location.reload();
86 var pageInstance = AdvancedOptions.getInstance(); 86 var pageInstance = AdvancedOptions.getInstance();
87 var topPage = OptionsPage.getTopmostVisiblePage(); 87 var topPage = OptionsPage.getTopmostVisiblePage();
88 var expectedTitle = pageInstance.title; 88 var expectedTitle = pageInstance.title;
89 var actualTitle = document.title; 89 var actualTitle = document.title;
90 assertEquals("chrome://settings/advanced", document.location.href); 90 assertEquals("chrome://settings/advanced", document.location.href);
91 assertEquals(expectedTitle, actualTitle); 91 assertEquals(expectedTitle, actualTitle);
92 assertEquals(pageInstance, topPage); 92 assertEquals(pageInstance, topPage);
93 }); 93 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698