Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/resources/options2/browser_options.html

Issue 9317114: Settings: Clean up browser_options page according to style guide. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <div id="browserPage" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="browserPage"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 <span id="browser-options-search-field-container" 4 <span id="browser-options-search-field-container"
5 class="search-field-container"> 5 class="search-field-container">
6 <input id="search-field" type="search" 6 <input id="search-field" type="search"
7 i18n-values="placeholder:searchPlaceholder; 7 i18n-values="placeholder:searchPlaceholder;
8 aria-label:searchPlaceholder" incremental> 8 aria-label:searchPlaceholder" incremental>
9 </span> 9 </span>
10 </header> 10 </header>
11 <if expr="not pp_ifdef('chromeos')"> 11 <if expr="not pp_ifdef('chromeos')">
12 <section id="sync-section"> 12 <section id="sync-section">
13 <h3 i18n-content="sectionTitleSync"></h3> 13 <h3 i18n-content="sectionTitleSync"></h3>
14 <div id="sync-overview" class="section-description" hidden> 14 <div id="sync-overview" class="section-description" hidden>
15 <p i18n-content="syncOverview"></p> 15 <p i18n-content="syncOverview"></p>
16 <a i18n-values="href:syncLearnMoreURL" i18n-content="learnMore" 16 <a i18n-values="href:syncLearnMoreURL" i18n-content="learnMore"
17 target="_blank"></a> 17 target="_blank">
18 </a>
18 </div> 19 </div>
19 <div id="sync-status" hidden> 20 <div id="sync-status" hidden>
20 <span id="sync-status-text"></span> 21 <span id="sync-status-text"></span>
21 <button id="sync-action-link" class="link-button"></button> 22 <button id="sync-action-link" class="link-button"></button>
22 </div> 23 </div>
23 <div id="sync-buttons"> 24 <div id="sync-buttons">
24 <button id="start-stop-sync" hidden></button> 25 <button id="start-stop-sync" hidden></button>
25 <button id="customize-sync" i18n-content="customizeSync" hidden> 26 <button id="customize-sync" i18n-content="customizeSync" hidden>
26 </button> 27 </button>
27 <div id="enable-auto-login-checkbox" class="checkbox" hidden> 28 <div id="enable-auto-login-checkbox" class="checkbox" hidden>
28 <label> 29 <label>
29 <input id="enable-auto-login" pref="autologin.enabled" 30 <input id="enable-auto-login" pref="autologin.enabled"
30 metric="Options_Autologin" type="checkbox"> 31 metric="Options_Autologin" type="checkbox">
31 <span i18n-content="autologinEnabled"></span> 32 <span i18n-content="autologinEnabled"></span>
32 </label> 33 </label>
33 </div> 34 </div>
34 </div> 35 </div>
35 </section> 36 </section>
36 </if> 37 </if>
37 <if expr="pp_ifdef('chromeos')"> 38 <if expr="pp_ifdef('chromeos')">
38 <section> 39 <section>
39 <h3 i18n-content="sectionTitleInternet"></h3> 40 <h3 i18n-content="sectionTitleInternet"></h3>
40 <div> 41 <div>
41 <button id="internet-options-button" 42 <button id="internet-options-button"
42 i18n-content="internetOptionsButtonTitle"></button> 43 i18n-content="internetOptionsButtonTitle">
44 </button>
43 </div> 45 </div>
44 </section> 46 </section>
45 </if> 47 </if>
46 <if expr="not pp_ifdef('chromeos')"> 48 <if expr="not pp_ifdef('chromeos')">
47 <!-- This section is temporarily duplicated down below for ChromeOS. --> 49 <!-- This section is temporarily duplicated down below for ChromeOS. -->
48 <section id="startupSection"> 50 <section id="startup-section">
49 <h3 i18n-content="sectionTitleStartup"></h3> 51 <h3 i18n-content="sectionTitleStartup"></h3>
50 <div> 52 <div>
51 <div class="radio"> 53 <div class="radio">
52 <label> 54 <label>
53 <input type="radio" name="startup" value="0" 55 <input type="radio" name="startup" value="0"
54 pref="session.restore_on_startup" 56 pref="session.restore_on_startup"
55 metric="Options_Startup_Homepage"> 57 metric="Options_Startup_Homepage">
56 <span i18n-content="startupShowDefaultAndNewTab"></span> 58 <span i18n-content="startupShowDefaultAndNewTab"></span>
57 </label> 59 </label>
58 </div> 60 </div>
59 <div class="radio"> 61 <div class="radio">
60 <label> 62 <label>
61 <input type="radio" name="startup" value="1" 63 <input type="radio" name="startup" value="1"
62 pref="session.restore_on_startup" 64 pref="session.restore_on_startup"
63 metric="Options_Startup_LastSession"> 65 metric="Options_Startup_LastSession">
64 <span id="old-startup-last-text" 66 <span id="old-startup-last-text"
65 i18n-content="startupShowLastSession"> 67 i18n-content="startupShowLastSession">
66 </span> 68 </span>
67 <span id="new-startup-last-text" 69 <span id="new-startup-last-text"
68 i18n-content="startupRestoreLastSession" hidden></span> 70 i18n-content="startupRestoreLastSession" hidden></span>
69 </label> 71 </label>
70 </div> 72 </div>
71 <div class="radio"> 73 <div class="radio">
72 <label> 74 <label>
73 <input id="startupShowPagesButton" type="radio" name="startup" 75 <input id="startup-show-pages" type="radio" name="startup"
74 pref="session.restore_on_startup" 76 pref="session.restore_on_startup"
75 value="4" metric="Options_Startup_Custom"> 77 value="4" metric="Options_Startup_Custom">
76 <span> 78 <span>
77 <span id="startupShowPagesLabel" 79 <span i18n-content="startupShowPages"></span>
78 i18n-content="startupShowPages"></span> 80 <button id="startup-set-pages" class="link-button"
79 <button id="startupSetPages" class="link-button"
80 i18n-content="startupSetPages"></button> 81 i18n-content="startupSetPages"></button>
81 </span> 82 </span>
82 </label> 83 </label>
83 </div> 84 </div>
84 </div> 85 </div>
85 </section> 86 </section>
86 </if> 87 </if>
87 <section> 88 <section>
88 <h3 i18n-content="sectionTitleAppearance"></h3> 89 <h3 i18n-content="sectionTitleAppearance"></h3>
89 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx"> 90 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx">
90 <div> 91 <div>
91 <div> 92 <button id="themes-gallery" i18n-content="themesGallery"></button>
92 <button id="themes-gallery" i18n-content="themesGallery"></button> 93 <button id="themes-GTK-button"
93 <button id="themes-GTK-button" 94 i18n-content="themesGTKButton"></button>
94 i18n-content="themesGTKButton"></button> 95 <button id="themes-reset"
95 <button id="themes-reset" 96 i18n-content="themesSetClassic"></button>
96 i18n-content="themesSetClassic"></button>
97 </div>
98 </div> 97 </div>
99 </if> 98 </if>
100 <if expr="pp_ifdef('toolkit_views') or os == 'win32' or os == 'darwin'"> 99 <if expr="pp_ifdef('toolkit_views') or os == 'win32' or os == 'darwin'">
101 <div> 100 <div>
102 <button id="themes-gallery" i18n-content="themesGallery"></button> 101 <button id="themes-gallery" i18n-content="themesGallery"></button>
103 <button id="themes-reset" i18n-content="themesReset"></button> 102 <button id="themes-reset" i18n-content="themesReset"></button>
104 </div> 103 </div>
105 </if> 104 </if>
106 <div> 105 <div>
107 <div class="checkbox"> 106 <div class="checkbox">
108 <input id="toolbarShowHomeButton" pref="browser.show_home_button" 107 <input id="toolbar-show-home-button" pref="browser.show_home_button"
109 metric="Options_Homepage_HomeButton" type="checkbox"> 108 metric="Options_Homepage_HomeButton" type="checkbox">
110 <label id="home-page-label" for="toolbarShowHomeButton" 109 <label id="home-page-label" for="toolbar-show-home-button"
111 i18n-content="toolbarShowHomeButton"> 110 i18n-content="toolbarShowHomeButton">
112 </label> 111 </label>
113 <button id="change-home-page" i18n-content="changeHomePage" 112 <button id="change-home-page" i18n-content="changeHomePage"
114 class="link-button"></button> 113 class="link-button">
114 </button>
115 </div> 115 </div>
116 <div class="checkbox"> 116 <div class="checkbox">
117 <label> 117 <label>
118 <input id="toolbarShowBookmarksBar" 118 <input type="checkbox" pref="bookmark_bar.show_on_all_tabs"
119 pref="bookmark_bar.show_on_all_tabs" 119 metric="Options_ShowBookmarksBar">
120 metric="Options_ShowBookmarksBar" type="checkbox">
121 <span i18n-content="toolbarShowBookmarksBar"></span> 120 <span i18n-content="toolbarShowBookmarksBar"></span>
122 </label> 121 </label>
123 </div> 122 </div>
124 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx"> 123 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx">
125 <div class="checkbox"> 124 <div class="checkbox">
126 <label> 125 <label>
127 <input id="show-window-decorations" type="checkbox" 126 <input id="show-window-decorations" type="checkbox"
128 pref="browser.custom_chrome_frame" metric="Options_CustomFrame" 127 pref="browser.custom_chrome_frame" metric="Options_CustomFrame"
129 inverted_pref> 128 inverted_pref>
130 <span i18n-content="showWindowDecorations"></span> 129 <span i18n-content="showWindowDecorations"></span>
(...skipping 12 matching lines...) Expand all
143 <input id="sensitivity-range" type="range" min="1" max="5" 142 <input id="sensitivity-range" type="range" min="1" max="5"
144 pref="settings.touchpad.sensitivity2" class="touch-slider"> 143 pref="settings.touchpad.sensitivity2" class="touch-slider">
145 <div> 144 <div>
146 <span i18n-content="pointerSensitivityLess"></span> 145 <span i18n-content="pointerSensitivityLess"></span>
147 <span id="pointer-sensitivity-more" 146 <span id="pointer-sensitivity-more"
148 i18n-content="pointerSensitivityMore"></span> 147 i18n-content="pointerSensitivityMore"></span>
149 </div> 148 </div>
150 </div> 149 </div>
151 </div> 150 </div>
152 <button id="pointer-settings-button" 151 <button id="pointer-settings-button"
153 i18n-content="pointerSettingsButtonTitle" hidden></button> 152 i18n-content="pointerSettingsButtonTitle" hidden>
153 </button>
154 </div> 154 </div>
155 <div> 155 <div>
156 <span i18n-content="deviceGroupKeyboard"></span> 156 <span i18n-content="deviceGroupKeyboard"></span>
157 <button id="keyboard-settings-button" 157 <button id="keyboard-settings-button"
158 i18n-content="keyboardSettingsButtonTitle"></button> 158 i18n-content="keyboardSettingsButtonTitle">
159 </button>
159 </div> 160 </div>
160 <div id="brightness-value"> 161 <div id="brightness-value">
161 <span i18n-content="deviceGroupBrightness"></span> 162 <span i18n-content="deviceGroupBrightness"></span>
162 <button id="brightness-decrease-button" 163 <button id="brightness-decrease-button"
163 i18n-content="brightnessDecrease"></button> 164 i18n-content="brightnessDecrease">
165 </button>
164 <button id="brightness-increase-button" 166 <button id="brightness-increase-button"
165 i18n-content="brightnessIncrease"></button> 167 i18n-content="brightnessIncrease">
168 </button>
166 </div> 169 </div>
167 </section> 170 </section>
168 </if> 171 </if>
169 <section> 172 <section>
170 <h3 i18n-content="sectionTitleSearch"></h3> 173 <h3 i18n-content="sectionTitleSearch"></h3>
171 <div id="defaultSearchEngineGroup"> 174 <div id="default-search-engine-group">
172 <div id="defaultSearchGroupLabel" 175 <div id="default-search-group-label"
173 i18n-values=".innerHTML:defaultSearchGroupLabel"></div> 176 i18n-values=".innerHTML:defaultSearchGroupLabel">
177 </div>
174 <div> 178 <div>
175 <select id="defaultSearchEngine" class="weakrtl"></select> 179 <select id="default-search-engine" class="weakrtl"></select>
176 <button id="defaultSearchManageEnginesButton" 180 <button id="manage-default-search-engines"
177 i18n-content="defaultSearchManageEngines"></button> 181 i18n-content="defaultSearchManageEngines">
182 </button>
178 </div> 183 </div>
179 <div id="instantOption" class="checkbox"> 184 <div id="instant-setting" class="checkbox">
180 <label id="instantLabel"> 185 <label id="instant-label">
181 <!-- TODO(estade): metric? --> 186 <!-- TODO(estade): metric? -->
182 <input id="instantFieldTrialCheckbox" type="checkbox" 187 <input id="instant-field-trial-control" type="checkbox"
183 checked="checked" hidden> 188 checked="checked" hidden>
184 <input id="instantEnabledCheckbox" type="checkbox" 189 <input id="instant-enabled-control" type="checkbox"
185 pref="instant.enabled"> 190 pref="instant.enabled">
186 <span i18n-values=".innerHTML:instantPrefAndWarning"></span> 191 <span i18n-values=".innerHTML:instantPrefAndWarning"></span>
187 </label> 192 </label>
188 </div> 193 </div>
189 </div> 194 </div>
190 </section> 195 </section>
191 <section> 196 <section>
192 <h3 i18n-content="sectionTitleUsers"></h3> 197 <h3 i18n-content="sectionTitleUsers"></h3>
193 <if expr="pp_ifdef('chromeos')"> 198 <if expr="pp_ifdef('chromeos')">
194 <div id="sync-section"> 199 <div id="sync-section">
(...skipping 17 matching lines...) Expand all
212 <label> 217 <label>
213 <input id="enable-screen-lock" type="checkbox" 218 <input id="enable-screen-lock" type="checkbox"
214 pref="settings.enable_screen_lock"> 219 pref="settings.enable_screen_lock">
215 <span i18n-content="enableScreenlock"></span> 220 <span i18n-content="enableScreenlock"></span>
216 </label> 221 </label>
217 </div> 222 </div>
218 <button id="change-picture-button" i18n-content="changePicture"> 223 <button id="change-picture-button" i18n-content="changePicture">
219 </button> 224 </button>
220 <button id="start-stop-sync" hidden></button> 225 <button id="start-stop-sync" hidden></button>
221 <button id="customize-sync" i18n-content="customizeSync" hidden> 226 <button id="customize-sync" i18n-content="customizeSync" hidden>
227 </button>
222 <button id="manage-accounts-button" 228 <button id="manage-accounts-button"
223 i18n-content="manageAccountsButtonTitle"></button> 229 i18n-content="manageAccountsButtonTitle">
224 </button> 230 </button>
225 </div> 231 </div>
226 </div> 232 </div>
227 </if> 233 </if>
228 <div id="profiles-section" hidden> 234 <div id="profiles-section" hidden>
229 <list id="profiles-list" class="settings-list" hidden></list> 235 <list id="profiles-list" class="settings-list" hidden></list>
230 <div id="profiles-single-message" i18n-content="profilesSingleUser"> 236 <div id="profiles-single-message" i18n-content="profilesSingleUser">
231 </div> 237 </div>
232 <div id="profiles-buttons"> 238 <div id="profiles-buttons">
233 <button id="profiles-create" i18n-content="profilesCreate"></button> 239 <button id="profiles-create" i18n-content="profilesCreate"></button>
234 <button id="profiles-manage" i18n-content="profilesManage" disabled> 240 <button id="profiles-manage" i18n-content="profilesManage" disabled>
235 </button> 241 </button>
236 <button id="profiles-delete" i18n-content="profilesDelete"> 242 <button id="profiles-delete" i18n-content="profilesDelete">
237 </button> 243 </button>
238 </div> 244 </div>
239 </div> 245 </div>
240 <if expr="not pp_ifdef('chromeos')"> 246 <if expr="not pp_ifdef('chromeos')">
241 <div id="manage-data-group"> 247 <div id="manage-data-group">
242 <div i18n-content="manageDataDescription"></div> 248 <div i18n-content="manageDataDescription"></div>
243 <div> 249 <div>
244 <button id="import-data" i18n-content="importData"></button> 250 <button id="import-data" i18n-content="importData"></button>
245 </div> 251 </div>
246 </div> 252 </div>
247 </if> 253 </if>
248 </section> 254 </section>
249 <if expr="not pp_ifdef('chromeos')"> 255 <if expr="not pp_ifdef('chromeos')">
250 <section> 256 <section>
251 <h3 i18n-content="sectionTitleDefaultBrowser"></h3> 257 <h3 i18n-content="sectionTitleDefaultBrowser"></h3>
252 <div> 258 <div>
253 <button id="defaultBrowserUseAsDefaultButton" 259 <button id="set-as-default-browser"
254 i18n-content="defaultBrowserUseAsDefault" hidden></button> 260 i18n-content="defaultBrowserUseAsDefault" hidden>
255 <div id="defaultBrowserState" 261 </button>
256 i18n-content="defaultBrowserUnknown"></div> 262 <div id="default-browser-state" i18n-content="defaultBrowserUnknown">
263 </div>
257 </div> 264 </div>
258 </section> 265 </section>
259 </if> 266 </if>
260 <if expr="pp_ifdef('chromeos')"> 267 <if expr="pp_ifdef('chromeos')">
261 <!-- This section is temporarily duplicated here for ChromeOS. --> 268 <!-- This section is temporarily duplicated here for ChromeOS. -->
262 <!-- TODO(csilv): Move to 'Under the Hood' for ChromeOS only. --> 269 <!-- TODO(csilv): Move to 'Under the Hood' for ChromeOS only. -->
263 <!-- http://crbug.com/110527 --> 270 <!-- http://crbug.com/110527 -->
264 <section id="startupSection"> 271 <section id="startup-section">
265 <h3 i18n-content="sectionTitleStartup"></h3> 272 <h3 i18n-content="sectionTitleStartup"></h3>
266 <div> 273 <div>
267 <div class="radio"> 274 <div class="radio">
268 <label> 275 <label>
269 <input type="radio" name="startup" value="0" 276 <input type="radio" name="startup" value="0"
270 pref="session.restore_on_startup" 277 pref="session.restore_on_startup"
271 metric="Options_Startup_Homepage"> 278 metric="Options_Startup_Homepage">
272 <span i18n-content="startupShowDefaultAndNewTab"></span> 279 <span i18n-content="startupShowDefaultAndNewTab"></span>
273 </label> 280 </label>
274 </div> 281 </div>
275 <div class="radio"> 282 <div class="radio">
276 <label> 283 <label>
277 <input type="radio" name="startup" value="1" 284 <input type="radio" name="startup" value="1"
278 pref="session.restore_on_startup" 285 pref="session.restore_on_startup"
279 metric="Options_Startup_LastSession"> 286 metric="Options_Startup_LastSession">
280 <span i18n-content="startupShowLastSession"></span> 287 <span i18n-content="startupShowLastSession"></span>
281 </label> 288 </label>
282 </div> 289 </div>
283 <div class="radio"> 290 <div class="radio">
284 <label> 291 <label>
285 <input id="startupShowPagesButton" type="radio" name="startup" 292 <input id="startup-show-pages" type="radio" name="startup"
286 pref="session.restore_on_startup" 293 pref="session.restore_on_startup"
287 value="4" metric="Options_Startup_Custom"> 294 value="4" metric="Options_Startup_Custom">
288 <span> 295 <span>
289 <span id="startupShowPagesLabel" 296 <span id="startupShowPagesLabel"
290 i18n-content="startupShowPages"></span> 297 i18n-content="startupShowPages">
291 <button id="startupSetPages" class="link-button" 298 </span>
292 i18n-content="startupSetPages"></button> 299 <button id="startup-set-pages" class="link-button"
300 i18n-content="startupSetPages">
301 </button>
293 </span> 302 </span>
294 </label> 303 </label>
295 </div> 304 </div>
296 </div> 305 </div>
297 </section> 306 </section>
298 </if> 307 </if>
299 <section> 308 <section>
300 <h3 i18n-content="sectionTitleAdvanced"></h3> 309 <h3 i18n-content="sectionTitleAdvanced"></h3>
301 <div> 310 <div>
302 <button id="advancedOptionsButton" 311 <button id="advanced-settings"
303 i18n-content="advancedOptionsButtonTitle"></button> 312 i18n-content="advancedSettings">
313 </button>
304 </div> 314 </div>
305 </section> 315 </section>
306 </div> 316 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698