Fix crash on startup because function returned before creating required

Fix crash on startup because function returned before creating required
members.  Finnur fixed a similar crash about a month ago (crrev.com/116316),
so I added some DCHECK()s to help prevent this in the future.

BUG=110234
TEST=This may happen when ResourceBundle::InitSharedInstanceWithLocale()
returns an empty string.  Not sure if there are other scenarios that would
cause this crash.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120788

[Finnur, 2012-02-06 09:52:27]

This change looks fine, per se, but what I don't understand is how we get to the
crash site given that I fixed the regression where failed to abort startup when
PreCreateThread returns failure. 

Do you know?

[Finnur, 2012-02-06 10:47:15]

Change LGTM. Feel free to answer the question after checking in.

[Roger Tawa OOO till Jul 10th, 2012-02-06 14:32:25]

Thanks Finnur.

I think your original fix was fine, but a new return was introduced afterwards. 
So I moved the creation of the two objects earlier in the function, and added 
the asserts in the wrapper to help catch this happening again.

I could just move the creation of the two objects right to the beginning of the
function though, maybe that would help minimize the error even more.  What do
you think?

[Finnur, 2012-02-06 14:49:37]

No, I think it is fine as is -- the DCHECK will take care of it. LGTM.

[Roger Tawa OOO till Jul 10th, 2012-02-06 14:59:29]

Cool, thanks Finnur.

[commit-bot: I haz the power, 2012-02-06 15:00:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/9317095/1

[commit-bot: I haz the power, 2012-02-06 18:37:34]

Try job failure for 9317095-1 (retry) (retry) (retry) on mac_rel for steps
"test_shell_tests, ui_tests".
It's a second try, previously, steps "test_shell_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-02-06 20:39:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/9317095/7004

[commit-bot: I haz the power, 2012-02-07 00:13:41]

Try job failure for 9317095-7004 (retry) (previous was lost) on mac_rel for step
"browser_tests".
It's a second try, previously, steps "base_unittests, browser_tests, ui_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...