Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 9317088: Merge 106636 - Crash when trying to add a timer to a detached document. (Closed)

Created:
8 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106636 - Crash when trying to add a timer to a detached document. https://bugs.webkit.org/show_bug.cgi?id=77692 Reviewed by Alexey Proskuryakov. In http://webkit.org/b/77370, a timer is fired on a detached document. Since a document clears all timers when it is detached, and it shouldn't be possible to add a timer to a detached document, we crash if this should happen anyway. This will hopefully result in an easier to debug crash dump. * page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=106682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/WebCore/page/DOMTimer.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years, 10 months ago (2012-02-03 20:07:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698