Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 9317085: linux: don't build gold as part of install-build-deps.sh (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 10 months ago
Reviewers:
Lei Zhang, tony, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

linux: don't build gold as part of install-build-deps.sh Now that it's in the tree we don't need to force everyone to build it. (Especially since the code to build it didn't put it in the path anyway.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121005

Patch Set 1 #

Patch Set 2 : up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -126 lines) Patch
M build/install-build-deps.sh View 3 chunks +0 lines, -126 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Martin
(won't land this until my change to use gold sticks) If you think this code ...
8 years, 10 months ago (2012-02-03 19:53:09 UTC) #1
Nico
I'll leave this one to Lei. Maybe want to sort out the 32bit story first. ...
8 years, 10 months ago (2012-02-03 19:55:33 UTC) #2
Evan Martin
On 2012/02/03 19:55:33, Nico wrote: > I'll leave this one to Lei. Maybe want to ...
8 years, 10 months ago (2012-02-03 20:02:57 UTC) #3
Evan Martin
+tony too since he asked about it
8 years, 10 months ago (2012-02-03 20:05:47 UTC) #4
Lei Zhang
On 2012/02/03 20:02:57, Evan Martin wrote: > On 2012/02/03 19:55:33, Nico wrote: > > I'll ...
8 years, 10 months ago (2012-02-03 20:39:48 UTC) #5
Lei Zhang
On 2012/02/03 19:55:33, Nico wrote: > I'll leave this one to Lei. Maybe want to ...
8 years, 10 months ago (2012-02-03 22:29:04 UTC) #6
Evan Martin
PTAR(econsideration) Now that I've updated the docs in third_party/gold, I think it's ok to delete ...
8 years, 10 months ago (2012-02-07 22:44:01 UTC) #7
Lei Zhang
On 2012/02/07 22:44:01, Evan Martin wrote: > PTAR(econsideration) > > Now that I've updated the ...
8 years, 10 months ago (2012-02-07 23:02:02 UTC) #8
Lei Zhang
> I'll add a few more works to third_party/gold/README.chromium s/works/words/
8 years, 10 months ago (2012-02-07 23:02:13 UTC) #9
Evan Martin
8 years, 10 months ago (2012-02-07 23:02:23 UTC) #10
make sure to "svn up" first

On Tue, Feb 7, 2012 at 3:02 PM,  <thestig@chromium.org> wrote:
> On 2012/02/07 22:44:01, Evan Martin wrote:
>>
>> PTAR(econsideration)
>
>
>> Now that I've updated the docs in third_party/gold, I think it's ok to
>> delete
>> this.
>
>
> LGTM
>
> I'll add a few more works to third_party/gold/README.chromium
>
> http://codereview.chromium.org/9317085/

Powered by Google App Engine
This is Rietveld 408576698