Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5470)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 9317072: Allow omitting optional parameters for Extensions API functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moved functions to json_schema.js and fixed naming conventions. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index eb3ef643f8140818d2456cf6a5f2834bc46e4de6..7db10eddf431dab9d0ae22a7e14400c7a93cda84 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -21,6 +21,7 @@ const char kChromeHidden[] = "chromeHidden";
#ifndef NDEBUG
const char kValidateCallbacks[] = "validateCallbacks";
+const char kValidateAPI[] = "validateAPI";
#endif
std::string GetContextTypeDescription(
@@ -69,8 +70,11 @@ v8::Handle<v8::Value> ChromeV8Context::GetOrCreateChromeHidden(
#ifndef NDEBUG
// Tell schema_generated_bindings.js to validate callbacks and events
// against their schema definitions.
- v8::Local<v8::Object>::Cast(hidden)
- ->Set(v8::String::New(kValidateCallbacks), v8::True());
+ v8::Local<v8::Object>::Cast(hidden)->Set(
+ v8::String::New(kValidateCallbacks), v8::True());
+ // Tell schema_generated_bindings.js to validate API for ambiguity.
+ v8::Local<v8::Object>::Cast(hidden)->Set(
+ v8::String::New(kValidateAPI), v8::True());
#endif
}

Powered by Google App Engine
This is Rietveld 408576698