Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8509)

Unified Diff: chrome/renderer/resources/extensions/windows_custom_bindings.js

Issue 9317072: Allow omitting optional parameters for Extensions API functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moved functions to json_schema.js and fixed naming conventions. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/windows_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/windows_custom_bindings.js b/chrome/renderer/resources/extensions/windows_custom_bindings.js
deleted file mode 100644
index c97a3a1b9d0efcd6a7029cca7736f0fcb9b4413b..0000000000000000000000000000000000000000
--- a/chrome/renderer/resources/extensions/windows_custom_bindings.js
+++ /dev/null
@@ -1,73 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Custom bindings for the windows API.
-
-(function() {
-
-native function GetChromeHidden();
-
-GetChromeHidden().registerCustomHook('windows', function(api) {
- var apiFunctions = api.apiFunctions;
-
- apiFunctions.setUpdateArgumentsPreValidate("windows.get", function() {
- // Old signature:
- // get(int windowId, function callback);
- // New signature:
- // get(int windowId, object populate, function callback);
- if (arguments.length == 2 && typeof(arguments[1]) == "function") {
- // If the old signature is used, add a null populate object.
- newArgs = [arguments[0], null, arguments[1]];
- } else {
- newArgs = arguments;
- }
- return newArgs;
- });
-
- apiFunctions.setUpdateArgumentsPreValidate("windows.getCurrent",
- function() {
- // Old signature:
- // getCurrent(function callback);
- // New signature:
- // getCurrent(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
- // If the old signature is used, add a null populate object.
- newArgs = [null, arguments[0]];
- } else {
- newArgs = arguments;
- }
- return newArgs;
- });
-
- apiFunctions.setUpdateArgumentsPreValidate("windows.getLastFocused",
- function() {
- // Old signature:
- // getLastFocused(function callback);
- // New signature:
- // getLastFocused(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
- // If the old signature is used, add a null populate object.
- newArgs = [null, arguments[0]];
- } else {
- newArgs = arguments;
- }
- return newArgs;
- });
-
- apiFunctions.setUpdateArgumentsPreValidate("windows.getAll", function() {
- // Old signature:
- // getAll(function callback);
- // New signature:
- // getAll(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
- // If the old signature is used, add a null populate object.
- newArgs = [null, arguments[0]];
- } else {
- newArgs = arguments;
- }
- return newArgs;
- });
-});
-
-})();

Powered by Google App Engine
This is Rietveld 408576698