Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 9317037: Fix lastchange.py when running on native win32 python (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Fix lastchange.py when running on native win32 python When running as runhooks, it's not run via cygwin like it was when run in the build, and isn't able to find git. I believe the test that checked for both cygwin and win32 before was incorrect (but was always run via cygwin before so didn't matter). Additionally, when runhooks runs it, it's from above src/, so the cwd isn't in the repo. So, pass in the directory of the script itself so that git can find its repo. BUG=112264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120110

Patch Set 1 #

Patch Set 2 : pass in valid cwd #

Patch Set 3 : match svn invocation for linux #

Patch Set 4 : rebase #

Patch Set 5 : fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/util/lastchange.py View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 10 months ago (2012-02-01 19:21:20 UTC) #1
M-A Ruel
:/ lgtm
8 years, 10 months ago (2012-02-01 19:23:19 UTC) #2
scottmg
On 2012/02/01 19:23:19, Marc-Antoine Ruel wrote: > :/ yah :( I made quite a mess. ...
8 years, 10 months ago (2012-02-01 19:25:21 UTC) #3
Peter Kasting
FWIW, I'm not convinced that "running under runhooks means this is not run via cygwin" ...
8 years, 10 months ago (2012-02-02 06:40:56 UTC) #4
M-A Ruel
On 2012/02/02 06:40:56, Peter Kasting wrote: > FWIW, I'm not convinced that "running under runhooks ...
8 years, 10 months ago (2012-02-02 14:17:08 UTC) #5
scottmg
8 years, 10 months ago (2012-02-02 18:04:02 UTC) #6
Sorry, yes, that should have read "may not be run via cygwin". I believe
the cygwin case should still work fine.

On Wed, Feb 1, 2012 at 10:40 PM, <pkasting@chromium.org> wrote:

> FWIW, I'm not convinced that "running under runhooks means this is not run
> via
> cygwin" -- I think it is more correct to say that running under runhooks
> means
> it MAY not be run via cygwin.  Hopefully this still works in that case.
>
> (I say this because I have a setup that forces the cygwin python first in
> the
> PATH rather than the depot_tools python.  I think this gives Marc-Antoine
> heartburn.)
>
>
https://chromiumcodereview.**appspot.com/9317037/<https://chromiumcodereview....
>

Powered by Google App Engine
This is Rietveld 408576698