Issue 9317034: Revert 120063 - Remove hand-rolled cases of protobufs generations/compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317034: Revert 120063 - Remove hand-rolled cases of protobufs generations/compilation (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)

Modified:
8 years, 10 months ago

Reviewers:
KushalP

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 120063 - Remove hand-rolled cases of protobufs generations/compilation using src/build/protoc.gypi to offer consistency between the other compilation steps, as well as ensuring that important variables (such as hard_dependency) are always properly set. BUG=109955 Review URL: http://codereview.chromium.org/9148084 TBR=kushi.p@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120066

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -18 lines)			Patch
	M	chrome/app/policy/cloud_policy_codegen.gyp	View		2 chunks	+55 lines, -13 lines	0 comments	Download
	M	net/test/test_server.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

8 years, 10 months ago (2012-02-01 16:17:25 UTC) #2

Caused on the Mac:

Updating projects from gyp files...
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 171, in <module>
    sys.exit(gyp.main(args))
  File "/Users/avi/Source/chrome-git/src/tools/gyp/pylib/gyp/__init__.py", line
480, in main
    generator.GenerateOutput(flat_list, targets, data, params)
  File
"/Users/avi/Source/chrome-git/src/tools/gyp/pylib/gyp/generator/xcode.py", line
903, in GenerateOutput
    AddSourceToTarget(output, pbxp, xct)
  File
"/Users/avi/Source/chrome-git/src/tools/gyp/pylib/gyp/generator/xcode.py", line
533, in AddSourceToTarget
    xct.SourcesPhase().AddFile(source)
AttributeError: 'PBXAggregateTarget' object has no attribute 'SourcesPhase'
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit
status 1 in /Users/avi/Source/chrome-git

Expand Messages | Collapse Messages