Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9317030: Fix test.dart on dartc client compilation tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 8147f612cd51dcc123bac94128c1af1d79c9e6d5..b247c77f7860087f418a784825bd86155bf93bd2 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -254,13 +254,14 @@ class StandardTestSuite implements TestSuite {
// rest. They use the .dart suffix in the status files. They
// find tests in weird ways (testing that they contain "#").
// They need to be redone.
- // directoryPath may start with '../'.
// TODO(1058): This does not work on Windows.
Mads Ager (google) 2012/02/01 12:57:46 Is this TODO obsolete?
- String sanitizedDirectoryPath = (directoryPath.startsWith('../')) ?
- directoryPath.substring(3) : directoryPath;
- start = filename.indexOf(sanitizedDirectoryPath);
- testName = filename.substring(start + sanitizedDirectoryPath.length + 1,
- filename.length);
+ start = filename.indexOf(directoryPath);
+ if (start != -1) {
+ testName = filename.substring(start + directoryPath.length + 1);
+ } else {
+ testName = filename;
+ }
+
if (configuration['component'] != 'dartc') {
if (testName.endsWith('.dart')) {
testName = testName.substring(0, testName.length - 5);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698