Issue 9317003: JPEG_DECODE_ONLY macro reintroduced to allow just the decode functions to be linked in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317003: JPEG_DECODE_ONLY macro reintroduced to allow just the decode functions to be linked in (Closed)

Created:
8 years, 10 months ago by fbarchard

Modified:
8 years, 10 months ago

Reviewers:
wjia(left Chromium), Hironori Bono

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libjpeg_turbo/

Visibility:
Public.

More Reviews

Description

JPEG_DECODE_ONLY macro reintroduced to allow just the decode functions to be linked in BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119959

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -10 lines)			Patch
	M	simd/jsimd_i386.c	View		13 chunks	+13 lines, -5 lines	0 comments	Download
	M	simd/jsimd_x86_64.c	View		13 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fbarchard

We used to have this JPEG_DECODE_ONLY but it didn't get upstreamed. Chromium itself doesnt use ...

8 years, 10 months ago (2012-01-31 19:26:16 UTC) #1

Hironori Bono

8 years, 10 months ago (2012-01-31 23:52:31 UTC) #3

LGTM with nits.
It seems our svn log does not have any changes of yours to these files. Have you
landed your previous change? Also, can you update README.chromium and describe
this change?

Regards,

Hironori Bono

On 2012/01/31 19:26:16, fbarchard wrote:
> We used to have this JPEG_DECODE_ONLY but it didn't get upstreamed.
> Chromium itself doesnt use it, since we do use JPEG compression, but
downstream
> webrtc/talk would like to use this source for just the decode functionality

Expand Messages | Collapse Messages