Issue 9316131: Properly initialize element-transitioning array literals on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9316131: Properly initialize element-transitioning array literals on ARM. (Closed)

Created:
8 years, 10 months ago by danno

Modified:
8 years, 10 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly initialize element-transitioning array literals on ARM. R=erikcorry@gmail.com BUG=v8:1930 TEST=unit tests with enable_vfp3=true Committed: https://code.google.com/p/v8/source/detail?r=10624

Patch Set 2 : Review feedback #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

https://chromiumcodereview.appspot.com/9316131/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/9316131/diff/1/src/arm/code-stubs-arm.cc#newcode7361 src/arm/code-stubs-arm.cc:7361: __ StoreNumberToDoubleElements(r0, r3, r1, r5, r6, r7, r9, r4, ...

8 years, 10 months ago (2012-02-07 08:07:44 UTC) #3

danno

Added commands and changed call to use a register that can be modified anyway to ...

8 years, 10 months ago (2012-02-07 08:40:59 UTC) #4

LGTM

Expand Messages | Collapse Messages

Issue 9316131: Properly initialize element-transitioning array literals on ARM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review feedback #

Messages