Issue 9316127: X64: Fix bug in minus-zero check after int32 multiplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9316127: X64: Fix bug in minus-zero check after int32 multiplication. (Closed)

Created:
8 years, 10 months ago by fschneider

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

X64: Fix bug in minus-zero check after int32 multiplication. In optimized x64 code, the check for minus zero after multiplication used the wrong size bit-or instruction (64-bit instead of 32-bit). TEST=mjsunit/numops-fuzz.js Committed: https://code.google.com/p/v8/source/detail?r=10606

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages