Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tools/code_hygiene.py

Issue 9316125: Adding untrusted crash dump / stack trace tests. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: add json escaping to fix windows Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/code_hygiene.py
diff --git a/tools/code_hygiene.py b/tools/code_hygiene.py
index 05d572b43f9b8e70bbc0a7b829905009d48c30a4..8438eb856206e08d702991bfc0090897f37e1c8c 100755
--- a/tools/code_hygiene.py
+++ b/tools/code_hygiene.py
@@ -1,5 +1,5 @@
#!/usr/bin/python
-# Copyright (c) 2011 The Native Client Authors. All rights reserved.
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -232,6 +232,7 @@ class UntrustedIfDefChecker(GenericRegexChecker):
if 'is_untrusted' not in props: return False
if 'is_untrusted_stubs' in props: return False
if 'is_untrusted_ehsupport' in props: return False
+ if 'is_untrusted_crash_dump' in props: return False
return '.c' in props or '.cc' in props
@@ -394,6 +395,10 @@ VALID_PROPS = {
'is_untrusted': True, # Is untrusted code.
'is_untrusted_stubs': True, # Is untrusted/stubs code.
'is_untrusted_ehsupport': True, # Is untrusted/ehsupport code.
+ 'is_untrusted_crash_dump': True, # Is untrusted/crash_dump code.
+ # Untrusted crash dumps need to vary by
+ # #ifdef __GLIBC__ because different
+ # memory layout information is available.
'is_shared': True, # Is shared code.
'is_scons': True, # Is scons file (not one generated by gyp).
}
@@ -457,6 +462,8 @@ def FileProperties(filename, data):
d['is_untrusted_stubs'] = True
if 'src/untrusted/ehsupport/' in filename:
d['is_untrusted_ehsupport'] = True
+ if 'src/untrusted/crash_dump/' in filename:
+ d['is_untrusted_crash_dump'] = True
if 'src/untrusted/' in filename:
d['is_untrusted'] = True
if 'src/shared/' in filename:

Powered by Google App Engine
This is Rietveld 408576698