Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: SConstruct

Issue 9316125: Adding untrusted crash dump / stack trace tests. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: code review comments 3 Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | site_scons/site_tools/naclsdk.py » ('j') | src/untrusted/crash_dump/decode_dump.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 8199beb07d7f134541078427f5d73c1a6a56bf53..ba23b8f4dc6bf6cace1906904995115e8241c0d0 100755
--- a/SConstruct
+++ b/SConstruct
@@ -1605,14 +1605,15 @@ def PPAPIBrowserTester(env,
continue
stream_file = env.subst(params['file'])
command.extend(['--nacl_exe_' + stream, stream_file])
- golden_file = env.subst(params['golden'])
- filter_regex = params.get('filter_regex', None)
- filter_inverse = params.get('filter_inverse', False)
- filter_group_only = params.get('filter_group_only', False)
- post_actions.append(
- GoldenFileCheckAction(
- env, stream_file, golden_file,
- filter_regex, filter_inverse, filter_group_only))
+ if 'golden' in params:
+ golden_file = env.subst(params['golden'])
+ filter_regex = params.get('filter_regex', None)
+ filter_inverse = params.get('filter_inverse', False)
+ filter_group_only = params.get('filter_group_only', False)
+ post_actions.append(
+ GoldenFileCheckAction(
+ env, stream_file, golden_file,
+ filter_regex, filter_inverse, filter_group_only))
if ShouldUseVerboseOptions(extra):
env.MakeVerboseExtraOptions(target, log_verbosity, extra)
@@ -3130,6 +3131,7 @@ nacl_env.Append(
'src/trusted/service_runtime/nacl.scons',
'src/trusted/validator_x86/nacl.scons',
'src/trusted/weak_ref/nacl.scons',
+ 'src/untrusted/crash_dump/nacl.scons',
'src/untrusted/irt_stub/nacl.scons',
'src/untrusted/nacl/nacl.scons',
'src/untrusted/nacl_ppapi_util/nacl.scons',
@@ -3219,6 +3221,7 @@ irt_variant_tests = [
'tests/toolchain/nacl.scons',
'tests/unittests/shared/platform/nacl.scons',
'tests/untrusted_check/nacl.scons',
+ 'tests/untrusted_crash_dump/nacl.scons',
#### ALPHABETICALLY SORTED ####
]
« no previous file with comments | « no previous file | site_scons/site_tools/naclsdk.py » ('j') | src/untrusted/crash_dump/decode_dump.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698