Adding untrusted crash dump / stack trace tests.

SConstruct

 #! -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import atexit
 import glob
 import os
 import platform
 import shutil
@@ skipping 1578 matching lines @@
                       'use --flag=value instead')
     command.extend(['--browser_flag', flag])
   for key, value in test_args:
     command.extend(['--test_arg', str(key), str(value)])
 
   # Set a given file to be the nexe's stdin.
   if nacl_exe_stdin is not None:
     command.extend(['--nacl_exe_stdin', env.subst(nacl_exe_stdin['file'])])
 
   post_actions = []
+  side_effects = []
   # Set a given file to be the nexe's stdout or stderr.  The tester also
   # compares this output against a golden file.
   for stream, params in (
       ('stdout', nacl_exe_stdout),
       ('stderr', nacl_exe_stderr)):
     if params is None:
       continue
     stream_file = env.subst(params['file'])
+    side_effects.append(stream_file)
     command.extend(['--nacl_exe_' + stream, stream_file])
-    golden_file = env.subst(params['golden'])
-    filter_regex = params.get('filter_regex', None)
-    filter_inverse = params.get('filter_inverse', False)
-    filter_group_only = params.get('filter_group_only', False)
-    post_actions.append(
-        GoldenFileCheckAction(
-            env, stream_file, golden_file,
-            filter_regex, filter_inverse, filter_group_only))
+    if 'golden' in params:
+      golden_file = env.subst(params['golden'])
+      filter_regex = params.get('filter_regex', None)
+      filter_inverse = params.get('filter_inverse', False)
+      filter_group_only = params.get('filter_group_only', False)
+      post_actions.append(
+          GoldenFileCheckAction(
+              env, stream_file, golden_file,
+              filter_regex, filter_inverse, filter_group_only))
 
   if ShouldUseVerboseOptions(extra):
     env.MakeVerboseExtraOptions(target, log_verbosity, extra)
   # Heuristic for when to capture output...
   capture_output = (extra.pop('capture_output', False)
                     or 'process_output_single' in extra)
   node = env.CommandTest(target,
                          command,
                          # Set to 'huge' so that the browser tester's timeout
                          # takes precedence over the default of the test_suite.
                          size='huge',
                          capture_output=capture_output,
                          **extra)
+  for side_effect in side_effects:
+    env.SideEffect(side_effect, node)
   # We can't check output if the test is not run.
   if not env.Bit('do_not_run_tests'):
     for action in post_actions:
       env.AddPostAction(node, action)
   return node
 
 pre_base_env.AddMethod(PPAPIBrowserTester)
 
 
 # Disabled for ARM because Chrome binaries for ARM are not available.
@@ skipping 1493 matching lines @@
           'src/shared/ppapi/nacl.scons',
           'src/shared/ppapi_proxy/nacl.scons',
           ])
 
 nacl_env.Append(
     BUILD_SCONSCRIPTS = [
     'src/shared/srpc/nacl.scons',
     'src/trusted/service_runtime/nacl.scons',
     'src/trusted/validator_x86/nacl.scons',
     'src/trusted/weak_ref/nacl.scons',
+    'src/untrusted/crash_dump/nacl.scons',
     'src/untrusted/irt_stub/nacl.scons',
     'src/untrusted/nacl/nacl.scons',
     'src/untrusted/nacl_ppapi_util/nacl.scons',
     'src/untrusted/pnacl_irt_shim/nacl.scons',
     'src/untrusted/pnacl_support_extension/nacl.scons',
     'src/untrusted/ppapi/nacl.scons',
     'src/untrusted/valgrind/nacl.scons',
     ####  ALPHABETICALLY SORTED ####
     ])
 
@@ skipping 69 matching lines @@
     'tests/sysbasic/nacl.scons',
     'tests/syscall_return_sandboxing/nacl.scons',
     'tests/syscalls/nacl.scons',
     'tests/threads/nacl.scons',
     'tests/time/nacl.scons',
     'tests/tls/nacl.scons',
     'tests/tls_perf/nacl.scons',
     'tests/toolchain/nacl.scons',
     'tests/unittests/shared/platform/nacl.scons',
     'tests/untrusted_check/nacl.scons',
+    'tests/untrusted_crash_dump/nacl.scons',
     #### ALPHABETICALLY SORTED ####
     ]
 
 # These are tests that are not worthwhile to run in an IRT variant.
 # In some cases, that's because they are browser tests which always
 # use the IRT.  In others, it's because they are special-case tests
 # that are incompatible with having an IRT loaded.
 nonvariant_tests = [
     #### ALPHABETICALLY SORTED ####
     'tests/barebones/nacl.scons',
@@ skipping 528 matching lines @@
   nacl_env.ValidateSdk()
 
 if BROKEN_TEST_COUNT > 0:
   msg = "There are %d broken tests." % BROKEN_TEST_COUNT
   if GetOption('brief_comstr'):
     msg += " Add --verbose to the command line for more information."
   print msg
 
 # separate warnings from actual build output
 Banner('B U I L D - O U T P U T:')