Adding untrusted crash dump / stack trace tests.

tools/code_hygiene.py

 #!/usr/bin/python
-# Copyright (c) 2011 The Native Client Authors. All rights reserved.
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Simple Code Hygiene tool meant to be run as a presubmit test or standalone
 
 Usage:
 ./code_hygiene.py <file1> <file2> ...
 
 For the styleguides see:
 http://code.google.com/p/soc/wiki/PythonStyleGuide
@@ skipping 212 matching lines @@
 class UntrustedIfDefChecker(GenericRegexChecker):
   """No #ifdef in untrusted code (except stubs)."""
   def __init__(self):
     GenericRegexChecker.__init__(self, r'^#if')
     return
 
   def FileFilter(self, props):
     if 'is_untrusted' not in props: return False
     if 'is_untrusted_stubs' in props: return False
     if 'is_untrusted_ehsupport' in props: return False
+    if 'is_untrusted_crash_dump' in props: return False

[Mark Seaborn, 2012/02/16 18:42:50]

This needs a comment: i.e. we need "#ifdef __GLIBC__"

[bradn, 2012/02/16 20:13:10]

Done.

     return '.c' in props or '.cc' in props
 
 
 class UntrustedAsmChecker(GenericRegexChecker):
   """No inline assembler in untrusted code."""
   def __init__(self):
     # TODO(robertm): also cope with asm
     GenericRegexChecker.__init__(self, r'__asm__')
     return
 
@@ skipping 142 matching lines @@
 # the magic string '@PROPS[prop1,prop2,...]' anywhere in the first 2k of
 # data.
 
 VALID_PROPS = {
     'name': True,                # Filename, only prop with a value.
     'is_makefile': True,
     'is_trusted': True,          # Is trusted code.
     'is_untrusted': True,        # Is untrusted code.
     'is_untrusted_stubs': True,  # Is untrusted/stubs code.
     'is_untrusted_ehsupport': True,  # Is untrusted/ehsupport code.
+    'is_untrusted_crash_dump': True,  # Is untrusted/crash_dump code.
     'is_shared': True,           # Is shared code.
     'is_scons': True,            # Is scons file (not one generated by gyp).
 }
 
 
 def IsValidProp(prop):
   """Returns true if the property name is valid.
 
   Valid property names start with '.' or are listed in VALID_PROPS.
 
@@ skipping 43 matching lines @@
 
   if 'akefile' in filename:
     d['is_makefile'] = True
 
   if 'src/trusted/' in filename:
     d['is_trusted'] = True
   if 'src/untrusted/stubs/' in filename:
     d['is_untrusted_stubs'] = True
   if 'src/untrusted/ehsupport/' in filename:
     d['is_untrusted_ehsupport'] = True
+  if 'src/untrusted/crash_dump/' in filename:
+    d['is_untrusted_crash_dump'] = True
   if 'src/untrusted/' in filename:
     d['is_untrusted'] = True
   if 'src/shared/' in filename:
     d['is_shared'] = True
 
   if (filename.endswith('nacl.scons') or
       filename.endswith('build.scons') or
       filename.endswith('SConstruct')):
       d['is_scons'] = True
 
@@ skipping 112 matching lines @@
       num_error += 1
       continue
 
     errors, warnings = CheckFile(filename, True)
     if errors:
       num_error += 1
   return num_error
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))