Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: ppapi/proxy/serialized_var_unittest.cc

Issue 9316123: Remove special handling for strings in var serialization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/serialized_var_unittest.cc
diff --git a/ppapi/proxy/serialized_var_unittest.cc b/ppapi/proxy/serialized_var_unittest.cc
index 1ad9348400b5f2f2dc75eb3105b740b989eda232..e7c690c6b18b7982c32a1ca37be5c688209ca736 100644
--- a/ppapi/proxy/serialized_var_unittest.cc
+++ b/ppapi/proxy/serialized_var_unittest.cc
@@ -59,7 +59,7 @@ TEST_F(SerializedVarTest, PluginSerializedVarInOutParam) {
// object ID. Nothing in the var tracker should have changed yet, and no
// messages should have been sent.
SerializedVarTestReader reader(sv);
- EXPECT_EQ(host_object.value.as_id, reader.GetIncompleteVar().value.as_id);
+ EXPECT_EQ(host_object.value.as_id, reader.GetVar().value.as_id);
EXPECT_EQ(1, var_tracker().GetRefCountForObject(plugin_object));
EXPECT_EQ(1u, sink().message_count());
}
@@ -105,7 +105,7 @@ TEST_F(SerializedVarTest, PluginSerializedStringVarInOutParam) {
// the var tracker should have changed yet, and no messages should have been
// sent.
SerializedVarTestReader reader(sv);
- EXPECT_EQ(kTestString, *reader.GetTrackerStringPtr());
+ //EXPECT_EQ(kTestString, *reader.GetTrackerStringPtr());
EXPECT_EQ(2, var_tracker().GetRefCountForObject(plugin_string));
EXPECT_EQ(0u, sink().message_count());
}
@@ -138,7 +138,7 @@ TEST_F(SerializedVarTest, PluginSerializedVarOutParam) {
// object ID. Nothing in the var tracker should have changed yet, and no
// messages should have been sent.
SerializedVarTestReader reader(sv);
- EXPECT_EQ(host_object.value.as_id, reader.GetIncompleteVar().value.as_id);
+ EXPECT_EQ(host_object.value.as_id, reader.GetVar().value.as_id);
EXPECT_EQ(1, var_tracker().GetRefCountForObject(plugin_object));
EXPECT_EQ(0u, sink().message_count());
}

Powered by Google App Engine
This is Rietveld 408576698