chrome/browser/plugin_installer.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_installer.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restored curlies to original. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_resource_throttle.cc ('K') | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_installer.cc

diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc

index 39643e444fe30b06a3e6a3d8571726b6dad34af0..36e2a09d4d5af508c14fdcdd019556422405cc8b 100644

--- a/chrome/browser/plugin_installer.cc

+++ b/chrome/browser/plugin_installer.cc

@@ -10,6 +10,7 @@

#include "base/process.h"

#include "chrome/browser/download/download_service_factory.h"

#include "chrome/browser/download/download_service.h"

+#include "chrome/browser/download/download_util.h"

#include "chrome/browser/platform_util.h"

#include "chrome/browser/plugin_installer_observer.h"

#include "chrome/browser/profiles/profile.h"

@@ -139,6 +140,8 @@ void PluginInstaller::StartInstalling(TabContentsWrapper* wrapper) {

content::WebContents* web_contents = wrapper->web_contents();

DownloadService* download_service =

DownloadServiceFactory::GetForProfile(wrapper->profile());

+ download_util::RecordDownloadSource(

+ download_util::INITIATED_BY_PLUGIN_INSTALLER);

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

base::Bind(&BeginDownload,