Isolate initiation counts for downloads to their own histograms and improve

chrome/browser/download/download_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download utilities.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_
 #pragma once
 
@@ skipping 156 matching lines @@
 bool IsSavableURL(const GURL& url);
 
 // Record the total number of items and the number of in-progress items showing
 // in the shelf when it closes.  Set |autoclose| to true when the shelf is
 // closing itself, false when the user explicitly closed it.
 void RecordShelfClose(int size, int in_progress, bool autoclose);
 
 // Used for counting UMA stats. Similar to content's
 // download_stats::DownloadCountTypes but from the chrome layer.
 enum ChromeDownloadCountTypes {
+  // A download *would* have been initiated, but it was blocked
+  // by the DownloadThrottlingResourceHandler.
+  BLOCKED_BY_THROTTLING = 0,
+
+  DOWNLOAD_COUNT_TYPES_LAST_ENTRY
+};
+
+// Used for counting UMA stats. Similar to content's
+// download_stats::DownloadInitiattionSources but from the chrome layer.
+enum ChromeDownloadInitiationSources {

[cbentzel, 2012/02/07 20:27:33]

Nit: why not ChromeDownloadSources? Or name RecordDownloadInitiationSource for
the function. Would be nice to be consistent.

[Randy Smith (Not in Mondays), 2012/02/09 21:48:02]

Tried to regularize naming; let me know if you have any opinions.

   // The download was initiated by navigating to a URL (e.g. by user click).
-  INITIATED_BY_NAVIGATION_COUNT = 0,
+  INITIATED_BY_NAVIGATION = 0,
 
   // The download was initiated by invoking a context menu within a page.
-  INITIATED_BY_CONTEXT_MENU_COUNT,
+  INITIATED_BY_CONTEXT_MENU,
 
   // The download was initiated by the WebStore installer.
-  INITIATED_BY_WEBSTORE_INSTALLER_COUNT,
+  INITIATED_BY_WEBSTORE_INSTALLER,
 
   // The download was initiated by the ImageBurner (cros).
-  INITIATED_BY_IMAGE_BURNER_COUNT,
+  INITIATED_BY_IMAGE_BURNER,
 
-  DOWNLOAD_COUNT_TYPES_LAST_ENTRY,
+  DOWNLOAD_INITIATION_SOURCES_LAST_ENTRY,
 };
 
+// Increment one of the above counts.
 void RecordDownloadCount(ChromeDownloadCountTypes type);
 
+// Record initiation of a download from a specific source.
+void RecordDownloadSource(ChromeDownloadInitiationSources source);
+
 }  // namespace download_util
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_