Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/browser/history/history.h

Issue 9316109: Move Ownership of IMUI to HistoryService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history.h
===================================================================
--- chrome/browser/history/history.h (revision 120346)
+++ chrome/browser/history/history.h (working copy)
@@ -43,6 +43,7 @@
namespace history {
class InMemoryHistoryBackend;
class InMemoryURLIndex;
+class InMemoryURLIndexTest;
class HistoryAddPageArgs;
class HistoryBackend;
class HistoryDatabase;
@@ -67,7 +68,7 @@
virtual bool RunOnDBThread(history::HistoryBackend* backend,
history::HistoryDatabase* db) = 0;
- // Invoked on the main thread once RunOnDBThread has returned false. This is
+ // Invoked on the main thread once RunOnDBThread has returned true. This is
// only invoked if the request was not canceled and returned true from
// RunOnDBThread.
virtual void DoneRunOnMainThread() = 0;
@@ -143,7 +144,9 @@
history::URLDatabase* InMemoryDatabase();
// Return the quick history index.
- history::InMemoryURLIndex* InMemoryIndex();
+ history::InMemoryURLIndex* InMemoryIndex() const {
+ return in_memory_url_index_.get();
+ }
// Navigation ----------------------------------------------------------------
@@ -590,6 +593,7 @@
friend class HistoryOperation;
friend class HistoryURLProvider;
friend class HistoryURLProviderTest;
+ friend class history::InMemoryURLIndexTest;
template<typename Info, typename Callback> friend class DownloadRequest;
friend class PageUsageRequest;
friend class RedirectRequest;
@@ -865,6 +869,9 @@
// True if needs top site migration.
bool needs_top_sites_migration_;
+ // The index used for quick history lookups.
+ scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_;
+
DISALLOW_COPY_AND_ASSIGN(HistoryService);
};

Powered by Google App Engine
This is Rietveld 408576698