Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: chrome/browser/history/in_memory_history_backend.h

Issue 9316109: Move Ownership of IMUI to HistoryService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/in_memory_history_backend.h
===================================================================
--- chrome/browser/history/in_memory_history_backend.h (revision 120346)
+++ chrome/browser/history/in_memory_history_backend.h (working copy)
@@ -41,16 +41,10 @@
virtual ~InMemoryHistoryBackend();
// Initializes the backend from the history database pointed to by the
- // full path in |history_filename|. |history_dir| is the path to the
- // directory containing the history database and is also used
- // as the directory where the InMemoryURLIndex's cache is kept. |db| is
- // used for building the InMemoryURLIndex. |languages| gives the
- // preferred user languages with which URLs and page titles are
- // interpreted while decomposing into words and characters during indexing.
+ // full path in |history_filename|. |db| is used for setting up the
+ // InMemoryDatabase.
bool Init(const FilePath& history_filename,
- const FilePath& history_dir,
- URLDatabase* db,
- const std::string& languages);
+ URLDatabase* db);
Peter Kasting 2012/02/04 02:20:31 Nit: Can probably fit on previous line?
mrossetti 2012/02/04 04:30:53 Done.
// Does initialization work when this object is attached to the history
// system on the main thread. The argument is the profile with which the
@@ -69,9 +63,6 @@
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // Return the quick history index.
- history::InMemoryURLIndex* InMemoryIndex() const { return index_.get(); }
-
private:
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteAll);
@@ -95,9 +86,6 @@
// initialization.
Profile* profile_;
- // The index used for quick history lookups.
- scoped_ptr<history::InMemoryURLIndex> index_;
-
DISALLOW_COPY_AND_ASSIGN(InMemoryHistoryBackend);
};

Powered by Google App Engine
This is Rietveld 408576698