Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 9316101: Revert 118950 - Allow chrome to handle 407 auth challenges to CONNECT requests (Closed)

Created:
8 years, 10 months ago by Ryan Hamilton
Modified:
8 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

Revert 118950 - Allow chrome to handle 407 auth challenges to CONNECT requests through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -956 lines) Patch
M jingle/notifier/base/proxy_resolving_client_socket.cc View 3 chunks +2 lines, -16 lines 0 comments Download
M net/base/net_error_list.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 12 chunks +10 lines, -565 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 7 chunks +17 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 9 chunks +46 lines, -12 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 8 chunks +1 line, -28 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 9 chunks +8 lines, -79 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 5 chunks +13 lines, -30 lines 0 comments Download
MM net/http/http_proxy_utils.h View 3 chunks +1 line, -10 lines 0 comments Download
MM net/http/http_proxy_utils.cc View 3 chunks +1 line, -17 lines 0 comments Download
MM net/http/http_stream_factory_impl_job.h View 5 chunks +1 line, -11 lines 0 comments Download
MM net/http/http_stream_factory_impl_job.cc View 5 chunks +12 lines, -37 lines 0 comments Download
MM net/http/http_stream_factory_impl_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM net/http/proxy_client_socket.h View 3 chunks +1 line, -11 lines 0 comments Download
MM net/socket/client_socket_pool_manager.h View 6 chunks +3 lines, -6 lines 0 comments Download
MM net/socket/client_socket_pool_manager.cc View 7 chunks +7 lines, -13 lines 0 comments Download
MM net/socket/ssl_client_socket_pool.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM net/socket/ssl_client_socket_pool_unittest.cc View 4 chunks +3 lines, -13 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket.h View 2 chunks +8 lines, -4 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket.cc View 6 chunks +13 lines, -27 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket_unittest.cc View 8 chunks +13 lines, -65 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Hamilton
8 years, 10 months ago (2012-02-03 19:50:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698