Fix for issue 1307: throw runtime exception instead of reporting a compile time error if a static...

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 12 matching lines @@
 
 DEFINE_FLAG(bool, enable_asserts, false, "Enable assert statements.");
 DEFINE_FLAG(bool, enable_type_checks, false, "Enable type checks.");
 DEFINE_FLAG(bool, trace_parser, false, "Trace parser operations.");
 DEFINE_FLAG(bool, warning_as_error, false, "Treat warnings as errors.");
 DEFINE_FLAG(bool, silent_warnings, false, "Silence warnings.");
 
 // All references to Dart names are listed here.
 static const char* kAssertionErrorName = "AssertionError";
 static const char* kFallThroughErrorName = "FallThroughError";
+static const char* kStaticResolutionExceptionName = "StaticResolutionException";
 static const char* kThrowNewName = "_throwNew";
 static const char* kListLiteralFactoryClassName = "_ListLiteralFactory";
 static const char* kListLiteralFactoryName = "List.fromLiteral";
 static const char* kMapLiteralFactoryClassName = "_MapLiteralFactory";
 static const char* kMapLiteralFactoryName = "Map.fromLiteral";
 static const char* kImmutableMapName = "ImmutableMap";
 static const char* kImmutableMapConstructorName = "ImmutableMap._create";
 static const char* kStringClassName = "StringBase";
 static const char* kInterpolateName = "_interpolate";
 static const char* kThisName = "this";
@@ skipping 5742 matching lines @@
         ASSERT(func.kind() != RawFunction::kConstImplicitGetter);
         closure = new StaticGetterNode(call_pos,
                                        Class::ZoneHandle(cls.raw()),
                                        func_name);
         return new ClosureCallNode(call_pos, closure, arguments);
       }
     } else {
       closure = GenerateStaticFieldLookup(field, call_pos);
       return new ClosureCallNode(call_pos, closure, arguments);
     }
-    ErrorMsg(ident_pos, "unresolved static method '%s'", func_name.ToCString());
+    // Could not resolve static method: throw an exception if the arguments
+    // do not match or compile time error otherwise.
+    const Function& test_func = Function::Handle(
+        Resolver::ResolveStaticByName(cls, func_name, Resolver::kIsQualified));
+    if (test_func.IsNull()) {
+      ErrorMsg(ident_pos, "unresolved static method '%s'",
+          func_name.ToCString());
+    } else {
+      ArgumentListNode* arguments = new ArgumentListNode(ident_pos);
+      arguments->Add(new LiteralNode(
+          token_index_, Integer::ZoneHandle(Integer::New(ident_pos))));
+      return MakeStaticCall(kStaticResolutionExceptionName,
+                            kThrowNewName,
+                            arguments);
+    }
   }
   CheckFunctionIsCallable(call_pos, func);
   return new StaticCallNode(call_pos, func, arguments);
 }
 
 
 AstNode* Parser::ParseInstanceCall(AstNode* receiver, const String& func_name) {
   const intptr_t call_pos = token_index_;
   if (CurrentToken() != Token::kLPAREN) {
     ErrorMsg(call_pos, "left parenthesis expected");
@@ skipping 1961 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart