Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4489)

Unified Diff: chrome/browser/resources/options2/search_page.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options2/search_engine_manager_engine_list.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/search_page.js
diff --git a/chrome/browser/resources/options2/search_page.js b/chrome/browser/resources/options2/search_page.js
index a947266e5ba3a3956b9e2134f5181d23ef1d2bcc..caaa647a1b67bad22882726dcc47f17c366e55e0 100644
--- a/chrome/browser/resources/options2/search_page.js
+++ b/chrome/browser/resources/options2/search_page.js
@@ -95,8 +95,8 @@ cr.define('options', function() {
this.style.top = top + 'px';
this.lastTop = top;
}
- }
- }
+ },
+ };
/**
* Encapsulated handling of the search page.
@@ -394,7 +394,7 @@ cr.define('options', function() {
* @param {RegEx} regex A regular expression for finding search matches.
* @param {String} replace A string to apply the replace operation.
* @param {Element} element An HTML container element.
- * @returns {Boolean} true if the element was changed.
+ * @return {boolean} true if the element was changed.
* @private
*/
performReplace_: function(regex, replace, element) {
@@ -425,7 +425,7 @@ cr.define('options', function() {
child = div.firstChild;
while (child = div.firstChild) {
node.parentNode.insertBefore(child, node);
- };
+ }
// Delete the old text node and advance the walker to the next
// node.
@@ -496,7 +496,7 @@ cr.define('options', function() {
/**
* Builds a list of top-level pages to search. Omits the search page and
* all sub-pages.
- * @returns {Array} An array of pages to search.
+ * @return {Array} An array of pages to search.
* @private
*/
getSearchablePages_: function() {
@@ -514,7 +514,7 @@ cr.define('options', function() {
/**
* Builds a list of sub-pages (and overlay pages) to search. Ignore pages
* that have no associated controls.
- * @returns {Array} An array of pages to search.
+ * @return {Array} An array of pages to search.
* @private
*/
getSearchableSubPages_: function() {
@@ -541,7 +541,7 @@ cr.define('options', function() {
const ESCAPE_KEY_CODE = 27;
const FORWARD_SLASH_KEY_CODE = 191;
- switch(event.keyCode) {
+ switch (event.keyCode) {
case ESCAPE_KEY_CODE:
if (event.target == this.searchField) {
this.setSearchText_('');
« no previous file with comments | « chrome/browser/resources/options2/search_engine_manager_engine_list.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698