Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4151)

Unified Diff: chrome/browser/resources/options2/options.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/options.js
diff --git a/chrome/browser/resources/options2/options.js b/chrome/browser/resources/options2/options.js
index 29a36025690b1aa87cf66b4d5176b4eba227535f..89809d9415302a3ffb0d2a0f2de062a7fea362b8 100644
--- a/chrome/browser/resources/options2/options.js
+++ b/chrome/browser/resources/options2/options.js
@@ -233,7 +233,7 @@ function load() {
}
var subpagesNavTabs = document.querySelectorAll('.subpages-nav-tabs');
- for(var i = 0; i < subpagesNavTabs.length; i++) {
+ for (var i = 0; i < subpagesNavTabs.length; i++) {
subpagesNavTabs[i].onclick = function(event) {
OptionsPage.showTab(event.srcElement);
}
@@ -248,10 +248,17 @@ function load() {
document.addEventListener('DOMContentLoaded', load);
+/**
+ * Listener for the |beforeunload| event.
+ */
window.onbeforeunload = function() {
options.OptionsPage.willClose();
};
+/**
+ * Listener for the |popstate| event.
+ * @param {Event} e The |popstate| event.
+ */
window.onpopstate = function(e) {
options.OptionsPage.setState(e.state);
};
« no previous file with comments | « chrome/browser/resources/options2/manage_profile_overlay.js ('k') | chrome/browser/resources/options2/options_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698