Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: chrome/browser/resources/options2/browser_options.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.js
diff --git a/chrome/browser/resources/options2/browser_options.js b/chrome/browser/resources/options2/browser_options.js
index 1fbe3cce331ade70497a647e0c82d70d7880e1ae..9465d1da607f741c6ced73322f19c6255bf23b13 100644
--- a/chrome/browser/resources/options2/browser_options.js
+++ b/chrome/browser/resources/options2/browser_options.js
@@ -350,8 +350,8 @@ cr.define('options', function() {
setInstantFieldTrialStatus_: function(enabled) {
$('instantEnabledCheckbox').hidden = enabled;
$('instantFieldTrialCheckbox').hidden = !enabled;
- $('instantLabel').htmlFor = enabled ? 'instantFieldTrialCheckbox'
- : 'instantEnabledCheckbox';
+ $('instantLabel').htmlFor = enabled ? 'instantFieldTrialCheckbox' :
+ 'instantEnabledCheckbox';
},
/**
@@ -404,10 +404,8 @@ cr.define('options', function() {
},
/**
- * Returns true if the custom startup page control block should
- * be enabled.
- * @returns {boolean} Whether the startup page controls should be
- * enabled.
+ * Returns true if the custom startup page control block should be enabled.
+ * @return {boolean} Whether the startup page controls should be enabled.
*/
shouldEnableCustomStartupPageControls: function(pages) {
return $('startupShowPagesButton').checked &&
@@ -532,7 +530,7 @@ cr.define('options', function() {
* iconURL: "chrome://path/to/icon/image",
* filePath: "/path/to/profile/data/on/disk",
* isCurrentProfile: false
- * };
+ * }.
James Hawkins 2012/02/03 01:28:24 Whatsup with this change?
Tyler Breisacher (Chromium) 2012/02/03 01:40:01 The description is a sentence so the linter wants
James Hawkins 2012/02/03 01:41:58 That's pretty ridiculous. This is quoted code, an
* @private
*/
setProfilesInfo_: function(profiles) {

Powered by Google App Engine
This is Rietveld 408576698