Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/resources/options2/handler_options_list.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 const ArrayDataModel = cr.ui.ArrayDataModel; 6 const ArrayDataModel = cr.ui.ArrayDataModel;
7 const List = cr.ui.List; 7 const List = cr.ui.List;
8 const ListItem = cr.ui.ListItem; 8 const ListItem = cr.ui.ListItem;
9 const HandlerOptions = options.HandlerOptions; 9 const HandlerOptions = options.HandlerOptions;
10 const DeletableItem = options.DeletableItem; 10 const DeletableItem = options.DeletableItem;
11 const DeletableItemList = options.DeletableItemList; 11 const DeletableItemList = options.DeletableItemList;
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 selectElement.appendChild(defaultOptionElement); 131 selectElement.appendChild(defaultOptionElement);
132 132
133 for (var i = 0; i < data.handlers.length; ++i) { 133 for (var i = 0; i < data.handlers.length; ++i) {
134 var optionElement = document.createElement('option'); 134 var optionElement = document.createElement('option');
135 optionElement.selected = i == data.default_handler; 135 optionElement.selected = i == data.default_handler;
136 optionElement.textContent = data.handlers[i][2]; 136 optionElement.textContent = data.handlers[i][2];
137 optionElement.value = i; 137 optionElement.value = i;
138 selectElement.appendChild(optionElement); 138 selectElement.appendChild(optionElement);
139 } 139 }
140 140
141 selectElement.addEventListener('change', function (e) { 141 selectElement.addEventListener('change', function(e) {
142 var index = e.target.value; 142 var index = e.target.value;
143 if (index == -1) { 143 if (index == -1) {
144 this.classList.add('none'); 144 this.classList.add('none');
145 delegate.clearDefault(data.protocol); 145 delegate.clearDefault(data.protocol);
146 } else { 146 } else {
147 handlerElement.classList.remove('none'); 147 handlerElement.classList.remove('none');
148 delegate.setDefault(data.handlers[index]); 148 delegate.setDefault(data.handlers[index]);
149 } 149 }
150 }); 150 });
151 handlerElement.appendChild(selectElement); 151 handlerElement.appendChild(selectElement);
152 handlerElement.className = 'handlers-site-column'; 152 handlerElement.className = 'handlers-site-column';
153 if (data.default_handler == -1) 153 if (data.default_handler == -1)
154 this.classList.add('none'); 154 this.classList.add('none');
155 this.appendChild(handlerElement); 155 this.appendChild(handlerElement);
156 156
157 // Remove link. 157 // Remove link.
158 var removeElement = document.createElement('div'); 158 var removeElement = document.createElement('div');
159 removeElement.textContent = 159 removeElement.textContent =
160 localStrings.getString('handlers_remove_link'); 160 localStrings.getString('handlers_remove_link');
161 removeElement.addEventListener('click', function (e) { 161 removeElement.addEventListener('click', function(e) {
162 var value = selectElement ? selectElement.value : 0; 162 var value = selectElement ? selectElement.value : 0;
163 delegate.removeHandler(value, data.handlers[value]); 163 delegate.removeHandler(value, data.handlers[value]);
164 }); 164 });
165 removeElement.className = 'handlers-remove-column handlers-remove-link'; 165 removeElement.className = 'handlers-remove-column handlers-remove-link';
166 this.appendChild(removeElement); 166 this.appendChild(removeElement);
167 }, 167 },
168 168
169 /** @inheritDoc */ 169 /** @inheritDoc */
170 decorate: function() { 170 decorate: function() {
171 ListItem.prototype.decorate.call(this); 171 ListItem.prototype.decorate.call(this);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 }, 220 },
221 }; 221 };
222 222
223 return { 223 return {
224 IgnoredHandlersListItem: IgnoredHandlersListItem, 224 IgnoredHandlersListItem: IgnoredHandlersListItem,
225 IgnoredHandlersList: IgnoredHandlersList, 225 IgnoredHandlersList: IgnoredHandlersList,
226 HandlerListItem: HandlerListItem, 226 HandlerListItem: HandlerListItem,
227 HandlersList: HandlersList, 227 HandlersList: HandlersList,
228 }; 228 };
229 }); 229 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options2/handler_options.js ('k') | chrome/browser/resources/options2/import_data_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698