Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: chrome/browser/resources/options2/content_settings_exceptions_area.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.contentSettings', function() { 5 cr.define('options.contentSettings', function() {
6 const InlineEditableItemList = options.InlineEditableItemList; 6 const InlineEditableItemList = options.InlineEditableItemList;
7 const InlineEditableItem = options.InlineEditableItem; 7 const InlineEditableItem = options.InlineEditableItem;
8 const ArrayDataModel = cr.ui.ArrayDataModel; 8 const ArrayDataModel = cr.ui.ArrayDataModel;
9 9
10 /** 10 /**
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 // Editing notifications and geolocation is disabled for now. 114 // Editing notifications and geolocation is disabled for now.
115 if (this.contentType == 'notifications' || 115 if (this.contentType == 'notifications' ||
116 this.contentType == 'location') { 116 this.contentType == 'location') {
117 this.editable = false; 117 this.editable = false;
118 } 118 }
119 119
120 // If the source of the content setting exception is not the user 120 // If the source of the content setting exception is not the user
121 // preference, then the content settings exception is managed and the user 121 // preference, then the content settings exception is managed and the user
122 // can't edit it. 122 // can't edit it.
123 if (this.dataItem.source && 123 if (this.dataItem.source &&
124 this.dataItem.source != 'preference') { 124 this.dataItem.source != 'preference') {
125 this.setAttribute('managedby', this.dataItem.source); 125 this.setAttribute('managedby', this.dataItem.source);
126 this.deletable = false; 126 this.deletable = false;
127 this.editable = false; 127 this.editable = false;
128 } 128 }
129 129
130 var listItem = this; 130 var listItem = this;
131 // Handle events on the editable nodes. 131 // Handle events on the editable nodes.
132 input.oninput = function(event) { 132 input.oninput = function(event) {
133 listItem.inputValidityKnown = false; 133 listItem.inputValidityKnown = false;
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 } 542 }
543 }; 543 };
544 544
545 return { 545 return {
546 ExceptionsListItem: ExceptionsListItem, 546 ExceptionsListItem: ExceptionsListItem,
547 ExceptionsAddRowListItem: ExceptionsAddRowListItem, 547 ExceptionsAddRowListItem: ExceptionsAddRowListItem,
548 ExceptionsList: ExceptionsList, 548 ExceptionsList: ExceptionsList,
549 ContentSettingsExceptionsArea: ContentSettingsExceptionsArea, 549 ContentSettingsExceptionsArea: ContentSettingsExceptionsArea,
550 }; 550 };
551 }); 551 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options2/content_settings.js ('k') | chrome/browser/resources/options2/controlled_setting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698