Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/resources/options2/advanced_options.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/resources/options2/autofill_edit_address_overlay.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 var OptionsPage = options.OptionsPage; 7 var OptionsPage = options.OptionsPage;
8 8
9 // 9 //
10 // AdvancedOptions class 10 // AdvancedOptions class
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 if ($('Custom')) 272 if ($('Custom'))
273 selectCtl.remove($('Custom').index); 273 selectCtl.remove($('Custom').index);
274 return; 274 return;
275 } 275 }
276 } 276 }
277 277
278 // Add/Select Custom Option in the font size label list. 278 // Add/Select Custom Option in the font size label list.
279 if (!$('Custom')) { 279 if (!$('Custom')) {
280 var option = new Option(localStrings.getString('fontSizeLabelCustom'), 280 var option = new Option(localStrings.getString('fontSizeLabelCustom'),
281 -1, false, true); 281 -1, false, true);
282 option.setAttribute("id", "Custom"); 282 option.setAttribute('id', 'Custom');
283 selectCtl.add(option); 283 selectCtl.add(option);
284 } 284 }
285 $('Custom').selected = true; 285 $('Custom').selected = true;
286 }; 286 };
287 287
288 /** 288 /**
289 * Populate the page zoom selector with values received from the caller. 289 * Populate the page zoom selector with values received from the caller.
290 * @param {Array} items An array of items to populate the selector. 290 * @param {Array} items An array of items to populate the selector.
291 * each object is an array with three elements as follows: 291 * each object is an array with three elements as follows:
292 * 0: The title of the item (string). 292 * 0: The title of the item (string).
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 if (device.pairing) 449 if (device.pairing)
450 BluetoothPairing.showDialog(device); 450 BluetoothPairing.showDialog(device);
451 }; 451 };
452 452
453 // Export 453 // Export
454 return { 454 return {
455 AdvancedOptions: AdvancedOptions 455 AdvancedOptions: AdvancedOptions
456 }; 456 };
457 457
458 }); 458 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/options2/autofill_edit_address_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698