Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 9316077: Enable audio/video tag in content_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix content_unittests Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 2b6815a71774626ec7ee37415812f0c5b15e2756..63c1f4006442b87ae5fdcb355b6edb40e18be85f 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -31,8 +31,7 @@ AudioRendererHost::AudioRendererHost(
content::ResourceContext* resource_context,
AudioManager* audio_manager)
: resource_context_(resource_context),
- audio_manager_(audio_manager),
- media_observer_(NULL) {
+ audio_manager_(audio_manager) {
}
AudioRendererHost::~AudioRendererHost() {
@@ -42,6 +41,9 @@ AudioRendererHost::~AudioRendererHost() {
void AudioRendererHost::OnChannelClosing() {
BrowserMessageFilter::OnChannelClosing();
+ // Channel is closing, so |resource_context_| is about to become invalid.
+ resource_context_ = NULL;
+
// Since the IPC channel is gone, close all requested audio streams.
DeleteEntries();
}
@@ -238,7 +240,8 @@ void AudioRendererHost::OnCreateStream(
// to the map.
entry->stream_id = stream_id;
audio_entries_.insert(std::make_pair(stream_id, entry.release()));
- GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "created");
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "created");
}
void AudioRendererHost::OnPlayStream(int stream_id) {
@@ -251,7 +254,8 @@ void AudioRendererHost::OnPlayStream(int stream_id) {
}
entry->controller->Play();
- GetMediaObserver()->OnSetAudioStreamPlaying(this, stream_id, true);
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamPlaying(this, stream_id, true);
}
void AudioRendererHost::OnPauseStream(int stream_id) {
@@ -264,7 +268,8 @@ void AudioRendererHost::OnPauseStream(int stream_id) {
}
entry->controller->Pause();
- GetMediaObserver()->OnSetAudioStreamPlaying(this, stream_id, false);
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamPlaying(this, stream_id, false);
}
void AudioRendererHost::OnFlushStream(int stream_id) {
@@ -277,13 +282,15 @@ void AudioRendererHost::OnFlushStream(int stream_id) {
}
entry->controller->Flush();
- GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "flushed");
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "flushed");
}
void AudioRendererHost::OnCloseStream(int stream_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "closed");
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamStatus(this, stream_id, "closed");
AudioEntry* entry = LookupById(stream_id);
@@ -304,7 +311,8 @@ void AudioRendererHost::OnSetVolume(int stream_id, double volume) {
if (volume < 0 || volume > 1.0)
return;
entry->controller->SetVolume(volume);
- GetMediaObserver()->OnSetAudioStreamVolume(this, stream_id, volume);
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamVolume(this, stream_id, volume);
}
void AudioRendererHost::SendErrorMessage(int32 stream_id) {
@@ -348,7 +356,8 @@ void AudioRendererHost::DeleteEntry(AudioEntry* entry) {
audio_entries_.erase(entry->stream_id);
// Notify the media observer.
- GetMediaObserver()->OnDeleteAudioStream(this, entry->stream_id);
+ if (GetMediaObserver())
+ GetMediaObserver()->OnDeleteAudioStream(this, entry->stream_id);
}
void AudioRendererHost::DeleteEntryOnError(AudioEntry* entry) {
@@ -358,7 +367,8 @@ void AudioRendererHost::DeleteEntryOnError(AudioEntry* entry) {
// |entry| is destroyed in DeleteEntry().
SendErrorMessage(entry->stream_id);
- GetMediaObserver()->OnSetAudioStreamStatus(this, entry->stream_id, "error");
+ if (GetMediaObserver())
+ GetMediaObserver()->OnSetAudioStreamStatus(this, entry->stream_id, "error");
CloseAndDeleteStream(entry);
}
@@ -387,7 +397,7 @@ AudioRendererHost::AudioEntry* AudioRendererHost::LookupByController(
content::MediaObserver* AudioRendererHost::GetMediaObserver() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- if (!media_observer_)
- media_observer_ = resource_context_->GetMediaObserver();
- return media_observer_;
+ if (resource_context_)
+ return resource_context_->GetMediaObserver();
+ return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698