Issue 9316073: Expose contextual menu state.

Issue 9316073: Expose contextual menu state. (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)

Modified:
8 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Expose contextual menu state. BUG=93804, 95573 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120237 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=120239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120247

Patch Set 5 : shared linux build fix #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -35 lines)			Patch
M	chrome/browser/tab_contents/moving_to_content/tab_contents_view_mac.mm	View	1 2 3	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view.h	View	1 2 3 4	3 chunks	+7 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view.cc	View	1 2 3 4	3 chunks	+7 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 2	3 chunks	+1 line, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.h	View	1 2	3 chunks	+1 line, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2	3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm https://chromiumcodereview.appspot.com/9316073/diff/1/content/browser/renderer_host/render_widget_host_view.cc File content/browser/renderer_host/render_widget_host_view.cc (right): https://chromiumcodereview.appspot.com/9316073/diff/1/content/browser/renderer_host/render_widget_host_view.cc#newcode53 content/browser/renderer_host/render_widget_host_view.cc:53: void RenderWidgetHostView::ShowingContextMenu(bool showing) { It's slightly confusing to ...

8 years, 10 months ago (2012-02-02 19:52:49 UTC) #2

Avi (use Gerrit)

8 years, 10 months ago (2012-02-02 20:02:23 UTC) #3

https://chromiumcodereview.appspot.com/9316073/diff/1/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view.cc (right):

https://chromiumcodereview.appspot.com/9316073/diff/1/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view.cc:53: void
RenderWidgetHostView::ShowingContextMenu(bool showing) {
On 2012/02/02 19:52:49, Ben Goodger (Google) wrote:
> It's slightly confusing to have this studlycaps setter that has a similar name
> to the accessor.
> 
> Can this be SetShowingContextMenu?

Yep!

Expand Messages | Collapse Messages