Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 9316040: Tests that should've been part of http://codereview.chromium.org/9117024 . (Closed)

Created:
8 years, 10 months ago by marja
Modified:
8 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Tests that should've been part of http://codereview.chromium.org/9117024 . BUG=99088 TEST=BrowserInitTest.ProfilesWithoutPagesNotLaunched Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M chrome/browser/ui/browser_init_browsertest.cc View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
marja
Hi sky, I should've added this test already to http://codereview.chromium.org/9117024 . Ptal.
8 years, 10 months ago (2012-02-01 17:46:33 UTC) #1
sky
LGTM
8 years, 10 months ago (2012-02-03 16:29:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/9316040/1
8 years, 10 months ago (2012-02-06 07:06:41 UTC) #3
commit-bot: I haz the power
Try job failure for 9316040-1 (retry) on mac_rel for step "update". It's a second try, ...
8 years, 10 months ago (2012-02-06 08:28:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/9316040/1
8 years, 10 months ago (2012-02-06 08:41:42 UTC) #5
commit-bot: I haz the power
Try job failure for 9316040-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=14170 Step "update" is always ...
8 years, 10 months ago (2012-02-06 08:50:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/9316040/1
8 years, 10 months ago (2012-02-06 10:20:29 UTC) #7
commit-bot: I haz the power
Try job failure for 9316040-1 (retry) (retry) on mac_rel for step "test_shell_tests". It's a second ...
8 years, 10 months ago (2012-02-06 13:14:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/9316040/1
8 years, 10 months ago (2012-02-06 14:43:56 UTC) #9
commit-bot: I haz the power
Try job failure for 9316040-1 (retry) (retry) on mac_rel for steps "test_shell_tests, ui_tests". It's a ...
8 years, 10 months ago (2012-02-06 17:27:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/9316040/1
8 years, 10 months ago (2012-02-07 09:57:00 UTC) #11
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 12:02:04 UTC) #12
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120749, job name
was 9316040-1 (previous was lost) (retry) (previous was lost) (previous was
lost).

Powered by Google App Engine
This is Rietveld 408576698