Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 9316039: Revert 120074 - Disable animations during aura tests. (Closed)

Created:
8 years, 10 months ago by Ian Vollick
Modified:
8 years, 10 months ago
Reviewers:
vollick1
CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, dcheng, piman+watch_chromium.org
Visibility:
Public.

Description

Revert 120074 - Disable animations during aura tests. This causes all animations scheduled during a test to complete immediately. After making this change, I noticed some code assumed that animations would not complete synchronously. Some of this code used animation observers, and I while fixing the code I have updated it to use the preferred ImplicitAnimationObserver. BUG=None TEST=aura_shell_unittests,aura_unittests,compositor_unittests Review URL: https://chromiumcodereview.appspot.com/9222018 TBR=vollick@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -303 lines) Patch
MM ash/app_list/app_list.h View 2 chunks +8 lines, -3 lines 0 comments Download
MM ash/app_list/app_list.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 2 chunks +9 lines, -4 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M ash/test/aura_shell_test_base.cc View 3 chunks +1 line, -5 lines 0 comments Download
M ash/wm/compact_layout_manager.h View 2 chunks +8 lines, -3 lines 0 comments Download
M ash/wm/compact_layout_manager.cc View 1 chunk +10 lines, -1 line 0 comments Download
MM ash/wm/shelf_layout_manager.h View 3 chunks +17 lines, -4 lines 0 comments Download
MM ash/wm/shelf_layout_manager.cc View 6 chunks +30 lines, -26 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.h View 2 chunks +8 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/visibility_controller_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/root_window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/gfx/compositor/layer_animation_observer.h View 4 chunks +19 lines, -39 lines 0 comments Download
M ui/gfx/compositor/layer_animation_observer.cc View 3 chunks +11 lines, -42 lines 0 comments Download
M ui/gfx/compositor/layer_animator.h View 3 chunks +6 lines, -16 lines 0 comments Download
M ui/gfx/compositor/layer_animator.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M ui/gfx/compositor/layer_animator_unittest.cc View 16 chunks +54 lines, -79 lines 0 comments Download
M ui/gfx/compositor/scoped_layer_animation_settings.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gfx/compositor/scoped_layer_animation_settings.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M ui/gfx/compositor/test/test_layer_animation_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/compositor/test/test_layer_animation_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ian Vollick
8 years, 10 months ago (2012-02-01 17:37:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698