Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: frog/leg/ssa/js_names.dart

Issue 9316026: Support named arguments for dynamic calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/ssa/codegen.dart ('k') | frog/leg/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/ssa/js_names.dart
===================================================================
--- frog/leg/ssa/js_names.dart (revision 3781)
+++ frog/leg/ssa/js_names.dart (working copy)
@@ -165,6 +165,12 @@
return _reserved;
}
+ // TODO(ngeoffray): only the namer should call this method.
+ // Eventually move it there.
+ /*
+ * Returns a name that does not clash with reserved JS keywords,
+ * and also ensures it won't clash with other identifiers.
+ */
static String getValid(String name) {
if (reserved.contains(name)) {
name = '\$$name';
« no previous file with comments | « frog/leg/ssa/codegen.dart ('k') | frog/leg/universe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698