Support named arguments for dynamic calls.

frog/leg/universe.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Universe {
   final Element scope;
 
   Map<SourceString, Element> elements;
   Map<Element, String> generatedCode;
   Map<Element, String> generatedBailoutCode;
@@ skipping 61 matching lines @@
   static final Selector UNARY_OPERATOR =
       const Selector(SelectorKind.OPERATOR, 0);
   static final Selector BINARY_OPERATOR =
       const Selector(SelectorKind.OPERATOR, 1);
   static final Selector INDEX = const Selector(SelectorKind.INDEX, 1);
   static final Selector INDEX_SET = const Selector(SelectorKind.INDEX, 2);
   static final Selector INDEX_AND_INDEX_SET =
       const Selector(SelectorKind.INDEX, 2);
   static final Selector GETTER_AND_SETTER =
       const Selector(SelectorKind.SETTER, 1);
-  static final Selector INVOCATION_0 = const Invocation(0);
+  static final Selector INVOCATION_0 =
+      const Selector(SelectorKind.INVOCATION, 0);
 
   bool applies(Compiler compiler, FunctionElement element) {
     FunctionParameters parameters = element.computeParameters(compiler);
     if (argumentCount > parameters.parameterCount) return false;
     int requiredParameterCount = parameters.requiredParameterCount;
     int optionalParameterCount = parameters.optionalParameterCount;
 
     bool hasOptionalParameters = !parameters.optionalParameters.isEmpty();
     if (namedArguments.isEmpty()) {
       if (!hasOptionalParameters) {
@@ skipping 32 matching lines @@
     }
     return true;
   }
 
   bool operator ==(other) {
     if (other is !Invocation) return false;
     return argumentCount == other.argumentCount
            && namedArguments.length == other.namedArguments.length
            && sameNames(namedArguments, other.namedArguments);
   }
+
+  void set orderedNamedArguments(List<SourceString> other) {
+    assert(other.length == 0);

[kasperl, 2012/02/01 10:21:21]

Add a comment that explains that it's okay to ignore other because it is empty?
Change other.length == 0 to other.isEmpty().

[ngeoffray, 2012/02/01 11:44:15]

Done.

+  }
+
+  String toString() => '$argumentCount';
 }
 
 class Invocation extends Selector {
   final List<SourceString> namedArguments;
+  List<SourceString> orderedNamedArguments;
   int get namedArgumentCount() => namedArguments.length;
   int get positionalArgumentCount() => argumentCount - namedArgumentCount;
 
-  const Invocation(
-      int argumentCount,
-      [List<SourceString> this.namedArguments = const <SourceString>[]])
-    : super(SelectorKind.INVOCATION, argumentCount);
+  Invocation(int argumentCount,
+             [List<SourceString> this.namedArguments = const <SourceString>[]])
+    : super(SelectorKind.INVOCATION, argumentCount),

[kasperl, 2012/02/01 10:21:21]

4 space indent?

[ngeoffray, 2012/02/01 11:44:15]

Done.

+      orderedNamedArguments = const <SourceString>[];
+
+  String toString() {
+    StringBuffer buffer = new StringBuffer();
+    buffer.add(argumentCount);
+    for (SourceString name in orderedNamedArguments) {
+      buffer.add('\$$name');
+    }
+    return buffer.toString();

[kasperl, 2012/02/01 10:21:21]

I might be inclined to remove the buffer.add(argumentCount) call and replace the
return line with:
  
  return "${argumentCount}${buffer}";

[ngeoffray, 2012/02/01 11:44:15]

Done.

+  }
 }